From 9903adf71b4556c7fc026702e600e33b13066418 Mon Sep 17 00:00:00 2001
From: ibuler <ibuler@qq.com>
Date: Thu, 18 Jul 2019 16:32:46 +0800
Subject: [PATCH] =?UTF-8?q?[Update]=20=E4=BF=AE=E6=94=B9cache=20policy=20?=
 =?UTF-8?q?=E5=BC=80=E5=85=B3?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

---
 apps/jumpserver/conf.py     | 1 +
 apps/jumpserver/settings.py | 1 +
 apps/perms/api/mixin.py     | 8 +++++++-
 3 files changed, 9 insertions(+), 1 deletion(-)

diff --git a/apps/jumpserver/conf.py b/apps/jumpserver/conf.py
index ce43c13b1..a6ef66413 100644
--- a/apps/jumpserver/conf.py
+++ b/apps/jumpserver/conf.py
@@ -378,6 +378,7 @@ defaults = {
     'LOGIN_LOG_KEEP_DAYS': 90,
     'ASSETS_PERM_CACHE_TIME': 3600*24,
     'SECURITY_MFA_VERIFY_TTL': 3600,
+    'ASSETS_PERM_CACHE_ENABLE': False,
 }
 
 
diff --git a/apps/jumpserver/settings.py b/apps/jumpserver/settings.py
index 6ee9f7a74..ba2fd7884 100644
--- a/apps/jumpserver/settings.py
+++ b/apps/jumpserver/settings.py
@@ -610,6 +610,7 @@ EMAIL_SUFFIX = CONFIG.EMAIL_SUFFIX
 LOGIN_LOG_KEEP_DAYS = CONFIG.LOGIN_LOG_KEEP_DAYS
 
 # User or user group permission cache time, default 3600 seconds
+ASSETS_PERM_CACHE_ENABLE = CONFIG.ASSETS_PERM_CACHE_ENABLE
 ASSETS_PERM_CACHE_TIME = CONFIG.ASSETS_PERM_CACHE_TIME
 
 # Asset user auth external backend, default AuthBook backend
diff --git a/apps/perms/api/mixin.py b/apps/perms/api/mixin.py
index 879965d4a..d06d37b55 100644
--- a/apps/perms/api/mixin.py
+++ b/apps/perms/api/mixin.py
@@ -28,6 +28,8 @@ def get_etag(request, *args, **kwargs):
     cache_policy = request.GET.get("cache_policy")
     if cache_policy != '1':
         return None
+    if not UserPermissionCacheMixin.CACHE_ENABLE:
+        return None
     view = request.parser_context.get("view")
     if not view:
         return None
@@ -38,6 +40,7 @@ def get_etag(request, *args, **kwargs):
 class UserPermissionCacheMixin:
     cache_policy = '0'
     RESP_CACHE_KEY = '_PERMISSION_RESPONSE_CACHE_V2_{}'
+    CACHE_ENABLE = settings.ASSETS_PERM_CACHE_ENABLE
     CACHE_TIME = settings.ASSETS_PERM_CACHE_TIME
     _object = None
 
@@ -111,7 +114,10 @@ class UserPermissionCacheMixin:
 
     @method_decorator(condition(etag_func=get_etag))
     def get(self, request, *args, **kwargs):
-        self.cache_policy = request.GET.get('cache_policy', '0')
+        if not self.CACHE_ENABLE:
+            self.cache_policy = '0'
+        else:
+            self.cache_policy = request.GET.get('cache_policy', '0')
 
         obj = self._get_object()
         if obj is None: