Merge pull request #9416 from jumpserver/pr@dev@fix_user_filter_role_error

fix: 修复用户过滤角色的错误
pull/9419/head
老广 2023-02-02 18:17:15 +08:00 committed by GitHub
commit 422bf92104
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 29 additions and 12 deletions

Binary file not shown.

Before

Width:  |  Height:  |  Size: 478 KiB

After

Width:  |  Height:  |  Size: 88 KiB

View File

@ -1,8 +1,10 @@
from django.utils.translation import gettext as _
from django_filters import rest_framework as filters
from common.drf.filters import BaseFilterSet
from users.models.user import User
from common.utils import is_uuid
from rbac.models import Role
from users.models.user import User
class UserFilter(BaseFilterSet):
@ -17,19 +19,34 @@ class UserFilter(BaseFilterSet):
)
@staticmethod
def filter_system_roles(queryset, name, value):
def get_role(value):
from rbac.builtin import BuiltinRole
roles = BuiltinRole.get_roles()
for role in roles.values():
if _(role.name) == value:
return role
if is_uuid(value):
return Role.objects.filter(id=value).first()
else:
return Role.objects.filter(name=value).first()
def filter_system_roles(self, queryset, name, value):
role = self.get_role(value)
if not role:
return queryset.none()
queryset = queryset.prefetch_related('role_bindings') \
.filter(
role_bindings__role__name=value,
role_bindings__role__scope='system'
).distinct()
.filter(role_bindings__role_id=role.id) \
.filter(role_bindings__role__scope='system') \
.distinct()
return queryset
@staticmethod
def filter_org_roles(queryset, name, value):
def filter_org_roles(self, queryset, name, value):
role = self.get_role(value)
if not role:
return queryset.none()
queryset = queryset.prefetch_related('role_bindings') \
.filter(
role_bindings__role__name=value,
role_bindings__role__scope='org'
).distinct()
.filter(role_bindings__role_id=role.id) \
.filter(role_bindings__role__scope='org') \
.distinct()
return queryset