From 19343540b93454abcae9f841c70e3b5523dfb9f8 Mon Sep 17 00:00:00 2001 From: Jiajun Liu Date: Fri, 3 Jul 2015 23:09:40 +0800 Subject: [PATCH] fix line break bug some system user '\n\r' as line break, if we split commands by '\n', then '\r' will be considered as part of commands which will break sudo authentication. we can use splitlines function to avoid the problem. --- jperm/views.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/jperm/views.py b/jperm/views.py index ec7f58d56..ebb12c7ea 100644 --- a/jperm/views.py +++ b/jperm/views.py @@ -484,7 +484,7 @@ def cmd_add(request): if request.method == 'POST': name = request.POST.get('name') dept_id = request.POST.get('dept_id') - cmd = ','.join(request.POST.get('cmd').split('\n')) + cmd = ','.join(request.POST.get('cmd').splitlines()) comment = request.POST.get('comment') dept = DEPT.objects.filter(id=dept_id) @@ -514,7 +514,7 @@ def cmd_add_adm(request): if request.method == 'POST': name = request.POST.get('name') - cmd = ','.join(request.POST.get('cmd').split('\n')) + cmd = ','.join(request.POST.get('cmd').splitlines()) comment = request.POST.get('comment') try: @@ -552,7 +552,7 @@ def cmd_edit(request): cmd_group_id = request.POST.get('cmd_group_id') name = request.POST.get('name') dept_id = request.POST.get('dept_id') - cmd = ','.join(request.POST.get('cmd').split('\n')) + cmd = ','.join(request.POST.get('cmd').splitlines()) comment = request.POST.get('comment') cmd_group = CmdGroup.objects.filter(id=cmd_group_id)