From 8b144a43d417778e68d90e016fc8af92e9c46b3b Mon Sep 17 00:00:00 2001
From: Gauthier LO <lo.gauthier.glo@gmail.com>
Date: Thu, 1 Aug 2024 11:57:12 +0200
Subject: [PATCH] feat: better logistic channel price comparison

---
 .../domain/logistic/CostTrialCalculation.java |  8 ++-
 .../mapper/LogisticChannelPriceMapper.java    |  7 ++-
 .../mapper/xml/LogisticChannelPriceMapper.xml | 61 ++++++++++++++++++-
 .../mapper/xml/ShippingInvoiceMapper.xml      |  2 +-
 .../impl/LogisticChannelPriceServiceImpl.java |  6 +-
 .../impl/LogisticChannelServiceImpl.java      | 13 +++-
 6 files changed, 85 insertions(+), 12 deletions(-)

diff --git a/jeecg-module-system/jeecg-system-biz/src/main/java/org/jeecg/modules/business/domain/logistic/CostTrialCalculation.java b/jeecg-module-system/jeecg-system-biz/src/main/java/org/jeecg/modules/business/domain/logistic/CostTrialCalculation.java
index 9a5cdc5bf..0e6a3f34f 100644
--- a/jeecg-module-system/jeecg-system-biz/src/main/java/org/jeecg/modules/business/domain/logistic/CostTrialCalculation.java
+++ b/jeecg-module-system/jeecg-system-biz/src/main/java/org/jeecg/modules/business/domain/logistic/CostTrialCalculation.java
@@ -24,6 +24,9 @@ public class CostTrialCalculation {
     @JsonFormat(timezone = "GMT+8", pattern = "yyyy-MM-dd")
     private final Date effectiveDate;
 
+    @JsonFormat(timezone = "GMT+8", pattern = "yyyy-MM-dd")
+    private final Date previousEffectiveDate;
+
     private final BigDecimal unitPrice;
 
     private final BigDecimal shippingCost;
@@ -44,7 +47,7 @@ public class CostTrialCalculation {
 
     private CostTrialCalculation(String countryCode, String logisticsChannelName, String logisticChannelCode,
                                  BigDecimal unitPrice, BigDecimal shippingCost, BigDecimal registrationCost, BigDecimal additionalCost, Date effectiveDate,
-                                 BigDecimal previousUnitPrice,BigDecimal previousShippingCost, BigDecimal previousRegistrationCost, BigDecimal previousAdditionalCost) {
+                                 BigDecimal previousUnitPrice,BigDecimal previousShippingCost, BigDecimal previousRegistrationCost, BigDecimal previousAdditionalCost, Date previousEffectiveDate) {
         this.countryCode = countryCode;
         this.logisticsChannelName = logisticsChannelName;
         this.logisticChannelCode = logisticChannelCode;
@@ -57,12 +60,13 @@ public class CostTrialCalculation {
         this.previousShippingCost = previousShippingCost;
         this.previousRegistrationCost = previousRegistrationCost;
         this.previousAdditionalCost = previousAdditionalCost;
+        this.previousEffectiveDate = previousEffectiveDate;
     }
 
     public CostTrialCalculation(LogisticChannelPrice price, LogisticChannelPrice previousPrice,int weight, String logisticsChannelName, String code) {
         this(price.getEffectiveCountry(), logisticsChannelName, code, price.getCalUnitPrice(), price.calculateShippingPrice(BigDecimal.valueOf(weight)),
                 price.getRegistrationFee(), price.getAdditionalCost(), price.getEffectiveDate(),
-                previousPrice.getCalUnitPrice(), previousPrice.calculateShippingPrice(BigDecimal.valueOf(weight)), previousPrice.getRegistrationFee(), previousPrice.getAdditionalCost()
+                previousPrice.getCalUnitPrice(), previousPrice.calculateShippingPrice(BigDecimal.valueOf(weight)), previousPrice.getRegistrationFee(), previousPrice.getAdditionalCost(), previousPrice.getEffectiveDate()
         );
     }
 
diff --git a/jeecg-module-system/jeecg-system-biz/src/main/java/org/jeecg/modules/business/mapper/LogisticChannelPriceMapper.java b/jeecg-module-system/jeecg-system-biz/src/main/java/org/jeecg/modules/business/mapper/LogisticChannelPriceMapper.java
index 955969d8f..f41f08280 100644
--- a/jeecg-module-system/jeecg-system-biz/src/main/java/org/jeecg/modules/business/mapper/LogisticChannelPriceMapper.java
+++ b/jeecg-module-system/jeecg-system-biz/src/main/java/org/jeecg/modules/business/mapper/LogisticChannelPriceMapper.java
@@ -34,7 +34,12 @@ public interface LogisticChannelPriceMapper extends BaseMapper<LogisticChannelPr
      * @param countryList      the country, represented by 2 letters code
      * @return one propre price
      */
-    List<LogisticChannelPrice> findBy(
+    LogisticChannelPrice findBy(
+            @Param("channelName") String channelName,
+            @Param("date") Date shippingTime,
+            @Param("trueWeight") BigDecimal weight,
+            @Param("countryList") List<String> countryList);
+    LogisticChannelPrice findPrevious(
             @Param("channelName") String channelName,
             @Param("date") Date shippingTime,
             @Param("trueWeight") BigDecimal weight,
diff --git a/jeecg-module-system/jeecg-system-biz/src/main/java/org/jeecg/modules/business/mapper/xml/LogisticChannelPriceMapper.xml b/jeecg-module-system/jeecg-system-biz/src/main/java/org/jeecg/modules/business/mapper/xml/LogisticChannelPriceMapper.xml
index a36890c23..5fdf2e8d4 100644
--- a/jeecg-module-system/jeecg-system-biz/src/main/java/org/jeecg/modules/business/mapper/xml/LogisticChannelPriceMapper.xml
+++ b/jeecg-module-system/jeecg-system-biz/src/main/java/org/jeecg/modules/business/mapper/xml/LogisticChannelPriceMapper.xml
@@ -33,8 +33,65 @@
           AND effective_date &lt;= #{date}
           AND active = 1
         ORDER BY effective_date DESC
-        LIMIT 2    </select>
-
+        LIMIT 1
+    </select>
+    <select id="findPrevious" resultType="org.jeecg.modules.business.entity.LogisticChannelPrice">
+        WITH current_price AS
+            (
+            SELECT lcp.*
+            FROM logistic_channel_price lcp
+            JOIN logistic_channel lc ON lc.id = lcp.channel_id
+            WHERE zh_name = #{channelName}
+            AND weight_range_start &lt;= #{trueWeight}
+            AND weight_range_end &gt;= #{trueWeight}
+            AND effective_country IN
+            <foreach collection="countryList"
+                     separator=","
+                     open="("
+                     close=")"
+                     index="index"
+                     item="country"
+            >
+                #{country}
+            </foreach>
+            AND effective_date &lt;= #{date}
+            AND active = 1
+            ORDER BY effective_date DESC
+            LIMIT 1
+            )
+        SELECT lcp.*
+        FROM logistic_channel_price lcp
+        JOIN logistic_channel lc ON lc.id = lcp.channel_id
+        WHERE lc.zh_name = #{channelName}
+        AND weight_range_start &lt;= #{trueWeight}
+        AND weight_range_end &gt;= #{trueWeight}
+        AND effective_country IN
+        <foreach collection="countryList"
+                 separator=","
+                 open="("
+                 close=")"
+                 index="index"
+                 item="country"
+        >#{country}
+        </foreach>
+        AND effective_date &lt;= #{date}
+        AND active = 1
+        AND (
+                lcp.cal_unit_price != (
+                SELECT cal_unit_price
+                FROM current_price
+                WHERE effective_country = lcp.effective_country
+                )
+                OR
+                lcp.registration_fee != (
+                SELECT registration_fee
+                FROM current_price
+                WHERE effective_country = lcp.effective_country
+                )
+            )
+        ORDER BY effective_date DESC
+        LIMIT 1;
+    </select>
     <select id="findPricesBy" resultType="org.jeecg.modules.business.entity.LogisticChannelPrice">
         SELECT lcp.id, lcp.create_by, lcp.create_time, lcp.update_by, lcp.update_time,
         lc.id AS channel_id, effective_date, effective_country,
diff --git a/jeecg-module-system/jeecg-system-biz/src/main/java/org/jeecg/modules/business/mapper/xml/ShippingInvoiceMapper.xml b/jeecg-module-system/jeecg-system-biz/src/main/java/org/jeecg/modules/business/mapper/xml/ShippingInvoiceMapper.xml
index 70a4f45ab..a959f6dd8 100644
--- a/jeecg-module-system/jeecg-system-biz/src/main/java/org/jeecg/modules/business/mapper/xml/ShippingInvoiceMapper.xml
+++ b/jeecg-module-system/jeecg-system-biz/src/main/java/org/jeecg/modules/business/mapper/xml/ShippingInvoiceMapper.xml
@@ -7,7 +7,7 @@
         FROM client c
             JOIN shop s ON c.id = s.owner_id
             JOIN platform_order po on s.id = po.shop_id
-        WHERE po.shipping_invoice_number = #{invoiceNumber}
+        WHERE po.shipping_invoice_number = #{invoiceNumber} OR po.purchase_invoice_number = #{invoiceNumber};
     </select>
     <select id="fetchShippingInvoiceId" resultType="java.lang.String">
         SELECT id
diff --git a/jeecg-module-system/jeecg-system-biz/src/main/java/org/jeecg/modules/business/service/impl/LogisticChannelPriceServiceImpl.java b/jeecg-module-system/jeecg-system-biz/src/main/java/org/jeecg/modules/business/service/impl/LogisticChannelPriceServiceImpl.java
index 5c86742de..22b5b1e37 100644
--- a/jeecg-module-system/jeecg-system-biz/src/main/java/org/jeecg/modules/business/service/impl/LogisticChannelPriceServiceImpl.java
+++ b/jeecg-module-system/jeecg-system-biz/src/main/java/org/jeecg/modules/business/service/impl/LogisticChannelPriceServiceImpl.java
@@ -90,16 +90,12 @@ public class LogisticChannelPriceServiceImpl extends ServiceImpl<LogisticChannel
 
         String countryCode = countryService.findByEnName(order.getCountry()).getCode();
 
-        List<LogisticChannelPrice> priceList = logisticChannelPriceMapper.findBy(
+        LogisticChannelPrice price = logisticChannelPriceMapper.findBy(
                 logisticChannelName,
                 order.getShippingTime(),
                 weight,
                 Collections.singletonList(countryCode)
         );
-        // find the one with latest effective date
-        LogisticChannelPrice price = priceList.stream()
-                .max(Comparator.comparing(LogisticChannelPrice::getEffectiveDate))
-                .orElse(null);
         if (price == null) {
             throw new UserException("Can't find price for channel {}, shipped at {}, weight {}, country {}",
                     logisticChannelName,
diff --git a/jeecg-module-system/jeecg-system-biz/src/main/java/org/jeecg/modules/business/service/impl/LogisticChannelServiceImpl.java b/jeecg-module-system/jeecg-system-biz/src/main/java/org/jeecg/modules/business/service/impl/LogisticChannelServiceImpl.java
index 83ac17176..7cca43e73 100644
--- a/jeecg-module-system/jeecg-system-biz/src/main/java/org/jeecg/modules/business/service/impl/LogisticChannelServiceImpl.java
+++ b/jeecg-module-system/jeecg-system-biz/src/main/java/org/jeecg/modules/business/service/impl/LogisticChannelServiceImpl.java
@@ -79,7 +79,16 @@ public class LogisticChannelServiceImpl extends ServiceImpl<LogisticChannelMappe
 
     @Override
     public List<LogisticChannelPrice> findLogisticsChannelPrice(String channelName, Date date, int trueWeight, List<String> countryList) {
-        return logisticChannelPriceMapper.findBy(channelName, new java.util.Date(), BigDecimal.valueOf(trueWeight), countryList);
+        List<LogisticChannelPrice> priceList = new ArrayList<>();
+        LogisticChannelPrice currentPrice = logisticChannelPriceMapper.findBy(channelName, new java.util.Date(), BigDecimal.valueOf(trueWeight), countryList);
+        if(currentPrice != null) {
+            priceList.add(currentPrice);
+            LogisticChannelPrice previousPrice = logisticChannelPriceMapper.findPrevious(channelName, new java.util.Date(), BigDecimal.valueOf(trueWeight), countryList);
+            if(previousPrice != null) {
+                priceList.add(previousPrice);
+            }
+        }
+        return priceList;
     }
 
     @Override
@@ -99,6 +108,8 @@ public class LogisticChannelServiceImpl extends ServiceImpl<LogisticChannelMappe
                         trueWeight = weight;
                     }
                     List<LogisticChannelPrice> priceList = findLogisticsChannelPrice(channelName, new Date(), trueWeight, countryList);
+                    System.out.println("Price list for " + channelName + " is : ");
+                    System.out.println(priceList);
                     LogisticChannelPrice price = priceList.stream()
                             .max(Comparator.comparing(LogisticChannelPrice::getEffectiveDate))
                             .orElse(null);