Hotfix: Use continue instead of break when parsing orders in AddGiftJob

pull/8547/head
Qiuyi LI 2025-06-26 16:02:47 +02:00
parent 03a1f0a667
commit 44dfe1250c
1 changed files with 3 additions and 2 deletions

View File

@ -177,7 +177,8 @@ public class AddGiftJob implements Job {
.filter(orderItem -> !orderItem.getStatus().equalsIgnoreCase(OBSOLETE_STATUS_CODE)) .filter(orderItem -> !orderItem.getStatus().equalsIgnoreCase(OBSOLETE_STATUS_CODE))
.collect(groupingBy(orderItem -> giftSkuSet.contains(orderItem.getErpCode()))); .collect(groupingBy(orderItem -> giftSkuSet.contains(orderItem.getErpCode())));
if (orderItemMap.isEmpty()) { if (orderItemMap.isEmpty()) {
break; log.info("No item in order {}, skipping", order.getPlatformOrderId());
continue;
} }
for (OrderItem orderItem : orderItemMap.get(Boolean.FALSE)) { for (OrderItem orderItem : orderItemMap.get(Boolean.FALSE)) {
String erpCode = orderItem.getErpCode(); String erpCode = orderItem.getErpCode();
@ -196,7 +197,7 @@ public class AddGiftJob implements Job {
} }
} }
} }
log.debug("Order {} 's new gift map : ", newGiftMap); log.info("Order {} 's new gift map : {}", order.getPlatformOrderId(), newGiftMap);
HashSet<Triple<String, String, Integer>> oldSkuData = new HashSet<>(); HashSet<Triple<String, String, Integer>> oldSkuData = new HashSet<>();
HashMap<String, Integer> oldGiftMap = new HashMap<>(); HashMap<String, Integer> oldGiftMap = new HashMap<>();
List<OrderItem> oldGifts = orderItemMap.get(Boolean.TRUE) == null ? new ArrayList<>() : orderItemMap.get(Boolean.TRUE); List<OrderItem> oldGifts = orderItemMap.get(Boolean.TRUE) == null ? new ArrayList<>() : orderItemMap.get(Boolean.TRUE);