Hotfix : Skip applying non-matching rules if there isn't any

pull/8040/head
Qiuyi LI 2024-10-28 11:21:18 +01:00
parent 404aaa3900
commit 38e2825f9b
1 changed files with 1 additions and 1 deletions

View File

@ -178,7 +178,7 @@ public class AddGiftJob implements Job {
.collect(groupingBy(orderItem -> giftSkuSet.contains(orderItem.getErpCode()))); .collect(groupingBy(orderItem -> giftSkuSet.contains(orderItem.getErpCode())));
for (OrderItem orderItem : orderItemMap.get(Boolean.FALSE)) { for (OrderItem orderItem : orderItemMap.get(Boolean.FALSE)) {
String erpCode = orderItem.getErpCode(); String erpCode = orderItem.getErpCode();
if (!nonMatchingRulesApplied) { if (!nonMatchingRulesApplied && !nonMatchingQuantityRules.isEmpty()) {
for (GiftRule giftRule : nonMatchingQuantityRules) { for (GiftRule giftRule : nonMatchingQuantityRules) {
if (erpCode.matches(giftRule.getRegex())) { if (erpCode.matches(giftRule.getRegex())) {
nonMatchingRulesApplied = true; nonMatchingRulesApplied = true;