From a63f9e2c7ce8698b8a11c889be7d746490ebfded Mon Sep 17 00:00:00 2001
From: Cees Bos <dev@ceesbos.nl>
Date: Tue, 1 Apr 2025 20:24:54 +0200
Subject: [PATCH] Rework Linkding integration based on feedback on the PR

---
 src/components/services/Linkding.vue | 47 +++++++++++++---------------
 1 file changed, 21 insertions(+), 26 deletions(-)

diff --git a/src/components/services/Linkding.vue b/src/components/services/Linkding.vue
index 97aab9a..0a9071d 100644
--- a/src/components/services/Linkding.vue
+++ b/src/components/services/Linkding.vue
@@ -1,8 +1,6 @@
 <template>
-  <template v-for="bookmark in bookmarks" :key="bookmark.name">
-      <Generic :item="bookmark">
-    </Generic>
-  </template>
+  <Generic v-for="bookmark in bookmarks" :key="bookmark.name" :item="bookmark">
+  </Generic>
 </template>
 
 <script>
@@ -16,16 +14,16 @@ export default {
   },
   mixins: [service],
   props: {
-    item: Object
+    item: Object,
   },
   data: () => ({
     bookmarks: [],
   }),
   computed: {
     calculatedLimit: function () {
-      let limit = this.item.limit ? this.item.limit : 5;
-      return Math.min(Math.max(limit,1),15);
-    }
+      const limit = parseInt(this.item.limit) || 5;
+      return Math.min(Math.max(limit, 1), 15);
+    },
   },
   created() {
     this.fetchBookmarks();
@@ -37,32 +35,29 @@ export default {
         Accept: "application/json",
       };
 
-      let limit = this.calculatedLimit;
-
-      let query = ''
+      let query = "";
       if (this.item.query) {
         query = `&q=${encodeURIComponent(this.item.query)}`;
       }
 
-      let url = `/api/bookmarks/?limit=${limit}${query}`;
+      let url = `/api/bookmarks/?limit=${this.calculatedLimit}${query}`;
 
       this.fetch(url, {
         headers,
       })
-          .then((ld_response) => {
-            this.bookmarks = ld_response.results.map(bookmark => ({
-              name: `${bookmark.title}`,
-              subtitle: `${bookmark.description}`,
-              url: bookmark.url,
-              logo: `${bookmark.favicon_url}`,
-              tag: `${bookmark.tag_names.join(" #")}`
-            }));
-          })
-          .catch((e) => {
-            console.log(e);
-            this.error = true;
-          });
+        .then((ld_response) => {
+          this.bookmarks = ld_response.results.map((bookmark) => ({
+            name: `${bookmark.title}`,
+            subtitle: `${bookmark.description}`,
+            url: bookmark.url,
+            logo: `${bookmark.favicon_url}`,
+            tag: `${bookmark.tag_names.join(" #")}`,
+          }));
+        })
+        .catch((e) => {
+          console.log(e);
+        });
     },
   },
 };
-</script>
\ No newline at end of file
+</script>