v7.3.2.0: Refactor server.js for improved readability and logic correction

The changes include better indentation for increased clarity. A sleep function with random duration was inserted into `serverIsUp` function for pacing. Additional changes include uncommenting server status messages and updating the attribute setting for 'slavefor' to reflect accurate data. Lastly, instead of removing the server_div on an error in the EventSource, the source itself is now closed.
pull/390/head
Aidaho 2024-07-20 08:56:11 +03:00
parent 74562243f3
commit dd86feb32f
1 changed files with 22 additions and 20 deletions

View File

@ -286,20 +286,20 @@ function cloneServer(id) {
}
}
function removeServer(id) {
$("#server-" + id).css("background-color", "#f2dede");
$.ajax({
url: "/app/server",
type: "DELETE",
data: JSON.stringify({'id': id}),
contentType: "application/json; charset=utf-8",
success: function (data) {
if (data.status === 'failed') {
toastr.error(data.error);
} else {
$("#server-" + id).remove();
}
}
});
$("#server-" + id).css("background-color", "#f2dede");
$.ajax({
url: "/app/server",
type: "DELETE",
data: JSON.stringify({'id': id}),
contentType: "application/json; charset=utf-8",
success: function (data) {
if (data.status === 'failed') {
toastr.error(data.error);
} else {
$("#server-" + id).remove();
}
}
});
}
function viewFirewallRules(ip) {
$.ajax({
@ -371,7 +371,9 @@ function showServerInfo(id, ip) {
}
});
}
function serverIsUp(server_id) {
async function serverIsUp(server_id) {
let random_sleep = getRandomArbitrary(1000, 10000);
await sleep(random_sleep);
const source = new EventSource(`/app/server/check/server/${server_id}`);
let server_div = $('#server_status-' + server_id);
source.onmessage = function (event) {
@ -380,17 +382,17 @@ function serverIsUp(server_id) {
server_div.removeClass('serverNone');
server_div.removeClass('serverDown');
server_div.addClass('serverUp');
// server_div.attr('title', 'Server is reachable');
server_div.attr('title', 'Server is reachable');
} else if (data.status === 'down') {
server_div.removeClass('serverNone');
server_div.removeClass('serverUp');
server_div.addClass('serverDown');
// server_div.attr('title', 'Server is unreachable');
server_div.attr('title', 'Server is unreachable');
} else {
server_div.removeClass('serverDown');
server_div.removeClass('serverUp');
server_div.addClass('serverNone');
// server_div.attr('title', 'Cannot get server status');
server_div.attr('title', 'Cannot get server status');
}
$('#hostname-' + server_id).val(data.name);
$('#ip-' + server_id).val(data.ip);
@ -416,13 +418,13 @@ function serverIsUp(server_id) {
$('#enable-' + server_id).checkboxradio("refresh");
$('#servergroup-' + server_id).val(data.group_id).change();
$('#credentials-' + server_id).val(data.creds_id).change();
$('#slavefor-' + server_id).val(data.creds_id).change();
$('#slavefor-' + server_id).val(data.slave).change();
$('#servergroup-' + server_id).selectmenu("refresh");
$('#credentials-' + server_id).selectmenu("refresh");
$('#slavefor-' + server_id).selectmenu("refresh");
}
source.onerror = function (event) {
server_div.remove();
source.close();
}
}
function openChangeServerServiceDialog(server_id) {