diff --git a/README.md b/README.md
index 458a1ec1..f6317535 100644
--- a/README.md
+++ b/README.md
@@ -1,4 +1,4 @@
-#Meet Haproxy-wi 2.0! Now with DB and Admin web interface! Life has become easier, life has become more cheerful!
+# Meet Haproxy-wi 2.0! Now with DB and Admin web interface! Life has become easier, life has become more cheerful!
# Haproxy web interface
A simple web interface(user-frendly web GUI) for managing Haproxy servers. Leave your [feedback](https://github.com/Aidaho12/haproxy-wi/issues)
diff --git a/cgi-bin/funct.py b/cgi-bin/funct.py
index ec91ec8c..0edb048f 100644
--- a/cgi-bin/funct.py
+++ b/cgi-bin/funct.py
@@ -161,7 +161,6 @@ def links():
'
')
@@ -323,7 +338,9 @@ def get_roles_select(id, **kwargs):
selected = ""
print('' % (role[1], selected, role[1]))
print('')
+
form = cgi.FieldStorage()
+error_mess = ' All fields must be completed X'
if form.getvalue('newusername') is not None:
email = form.getvalue('newemail')
@@ -333,11 +350,11 @@ if form.getvalue('newusername') is not None:
new_user = form.getvalue('newusername')
if password is None or role is None or group is None:
print('Content-type: text/html\n')
- print("All fields must be completed")
+ print(error_mess)
else:
print('Content-type: text/html\n')
- add_user(new_user, email, password, role, group)
- show_update_user(new_user)
+ if add_user(new_user, email, password, role, group):
+ show_update_user(new_user)
if form.getvalue('updateuser') is not None:
email = form.getvalue('email')
@@ -348,7 +365,7 @@ if form.getvalue('updateuser') is not None:
id = form.getvalue('id')
if password is None or role is None or group is None:
print('Content-type: text/html\n')
- print("All fields must be completed")
+ print(error_mess)
else:
print('Content-type: text/html\n')
update_user(new_user, email, password, role, group, id)
@@ -364,11 +381,11 @@ if form.getvalue('newserver') is not None:
group = form.getvalue('newservergroup')
if ip is None or group is None:
print('Content-type: text/html\n')
- print("All fields must be completed")
+ print(error_mess)
else:
print('Content-type: text/html\n')
- add_server(hostname, ip, group)
- show_update_server(hostname)
+ if add_server(hostname, ip, group):
+ show_update_server(hostname)
if form.getvalue('serverdel') is not None:
print('Content-type: text/html\n')
@@ -379,8 +396,8 @@ if form.getvalue('newgroup') is not None:
newgroup = form.getvalue('newgroup')
desc = form.getvalue('newdesc')
print('Content-type: text/html\n')
- add_group(newgroup, desc)
- show_update_group(newgroup)
+ if add_group(newgroup, desc):
+ show_update_group(newgroup)
if form.getvalue('groupdel') is not None:
print('Content-type: text/html\n')
@@ -393,7 +410,7 @@ if form.getvalue('updategroup') is not None:
id = form.getvalue('id')
if name is None:
print('Content-type: text/html\n')
- print("All fields must be completed")
+ print(error_mess)
else:
print('Content-type: text/html\n')
update_group(name, descript, id)
@@ -405,7 +422,7 @@ if form.getvalue('updateserver') is not None:
id = form.getvalue('id')
if name is None or ip is None:
print('Content-type: text/html\n')
- print("All fields must be completed")
+ print(error_mess)
else:
print('Content-type: text/html\n')
update_server(name, ip, group, id)
diff --git a/cgi-bin/users.py b/cgi-bin/users.py
index 214c623f..1a866614 100644
--- a/cgi-bin/users.py
+++ b/cgi-bin/users.py
@@ -74,7 +74,7 @@ sql.get_roles_select("new-role")
print('