github/halo - halo - https://git.xinac.net

Go to file

guqing 9bea5ef1c9 fix: inconsistency status occurred during plugin startup due to optimistic locking conflict (#4275 ) #### What type of PR is this? /kind improvement /area core /area plugin /milestone 2.7.x #### What this PR does / why we need it: 修复插件启动成功但更新数据失败而导致插件状态不符合预期的问题 how to test it? 1. 安装一个带 console 页面的插件并停用它 2. 使用 IDEA 在 doStart 方法最后更新数据的地方也就是 `834e37cf13/application/src/main/java/run/halo/app/core/extension/reconciler/PluginReconciler.java (L447)` 处打断点，suspend 勾选为 Thread <img width="404" alt="image" src="https://github.com/halo-dev/halo/assets/38999863/ead0ad2c-65a9-41aa-b2b1-f4fdbc2d2edf"> 3. 启用插件,会执行到断点处 4. 使用如下命令更新数据将 status 删除以模拟乐观锁冲突并清除 status 状态排除干扰 ```shell curl -u admin:admin -X PUT http://localhost:8090/apis/plugin.halo.run/v1alpha1/plugins/{name} --data '替换为 plugin 的 json ' ``` 5. 放行端点根据上述步骤先在 main 分支浮现然后在切换到此 PR 对比结果，期望插件的状态为启动成功且 status 数据示例如下： conditions 有两条会因为乐观锁更新失败一次且entry和stylesheet都有值 ```json { "phase": "STARTED", "conditions": [ { "type": "STARTED", "status": "TRUE", "lastTransitionTime": "2023-07-21T07:46:01.274211Z", "message": "Started successfully", "reason": "STARTED" }, { "type": "FAILED", "status": "FALSE", "lastTransitionTime": "2023-07-21T07:46:01.248001Z", "message": "Failed to update table [extensions]; Version does not match for row with Id [/registry/plugin.halo.run/plugins/PluginBytemd]", "reason": "UnexpectedState" } ], "lastStartTime": "2023-07-21T07:46:01.273625Z", "entry": "/plugins/PluginBytemd/assets/console/main.js?version=1.1.0-SNAPSHOT", "stylesheet": "/plugins/PluginBytemd/assets/console/style.css?version=1.1.0-SNAPSHOT", "logo": "/plugins/PluginBytemd/assets/logo.png?version=1.1.0-SNAPSHOT", "loadLocation": "file:///Users/guqing/Development/halo-sigs/plugin-bytemd/" } ``` #### Which issue(s) this PR fixes: Fixes #4273 #### Does this PR introduce a user-facing change? ```release-note 修复插件启动成功但更新数据失败而导致插件状态不符合预期的问题 ```		2023-07-24 08:22:42 +00:00
.github	chore: add sponsorship entry and sponsor image (#4233 )	2023-07-16 16:14:19 +00:00
api	feat: add support for user avatar upload (#4253 )	2023-07-24 08:08:04 +00:00
application	fix: inconsistency status occurred during plugin startup due to optimistic locking conflict (#4275 )	2023-07-24 08:22:42 +00:00
buildSrc	Support publishing to maven central repository (#3767 )	2023-04-18 14:28:23 +08:00
config/checkstyle	chore: add checkstyle rule (#2091 )	2022-05-17 06:46:11 +00:00
console	feat: add support for user avatar upload (#4253 )	2023-07-24 08:08:04 +00:00
docs	Enable configuration caching with separate names (#4151 )	2023-06-29 07:02:11 +00:00
gradle/wrapper	Upgrade to Gradle 8.0.2 (#3543 )	2023-03-21 02:44:27 +00:00
hack	chore: add cherry_pick_pull.sh for cherry-picking pull request (#1554 )	2021-12-03 10:21:24 +08:00
platform	Upgrade Spring Boot 3.1.2 (#4284 )	2023-07-24 03:20:14 +00:00
.dockerignore	Refactor project structure for a better development (#3552 )	2023-03-23 08:02:33 +00:00
.editorconfig	feat: support for obtaining the newest comments on theme-side (#4104 )	2023-06-28 15:48:11 +00:00
.gitattributes	Refactor .gitignore	2019-04-03 11:37:59 +08:00
.gitignore	Refactor project structure for a better development (#3552 )	2023-03-23 08:02:33 +00:00
CODE_OF_CONDUCT.md	docs: add CODE_OF_CONDUCT.md (#2150 )	2022-06-12 08:10:12 +00:00
CONTRIBUTING.md	chore: add cherry_pick_pull.sh for cherry-picking pull request (#1554 )	2021-12-03 10:21:24 +08:00
Dockerfile	Refactor project structure for a better development (#3552 )	2023-03-23 08:02:33 +00:00
LICENSE	Create LICENSE	2018-03-21 21:39:46 +08:00
OWNERS	chore: add @LIlGG to reviewers list (#3292 )	2023-02-13 01:48:18 +00:00
README.md	chore: add sponsorship entry and sponsor image (#4233 )	2023-07-16 16:14:19 +00:00
SECURITY.md	docs: update SECURITY.md for Halo 2.x (#3780 )	2023-04-19 02:47:00 +00:00
gradle.properties	Prepare for next release 2.8.0 (#4168 )	2023-06-30 07:44:13 +00:00
gradlew	Upgrade to Gradle 8.0.2 (#3543 )	2023-03-21 02:44:27 +00:00
gradlew.bat	Upgrade to Gradle 8.0.2 (#3543 )	2023-03-21 02:44:27 +00:00
settings.gradle	Refactor project structure for a better development (#3552 )	2023-03-23 08:02:33 +00:00

README.md

Halo [ˈheɪloʊ]，强大易用的开源建站工具。

官网文档社区 Gitee Telegram 频道

快速开始

docker run \
  -it -d \
  --name halo \
  -p 8090:8090 \
  -v ~/.halo2:/root/.halo2 \
  halohub/halo:2.7 \
  --halo.security.initializer.superadminusername=admin \
  --halo.security.initializer.superadminpassword=P@88w0rd