github
/
halo
mirror of https://github.com/halo-dev/halo
1
0
Fork 0
Code Issues Releases Wiki Activity

Change type of SettingFetcher from interface into abstract class (#3593) 

#### What type of PR is this?

/kind bug
/area core

#### What this PR does / why we need it:

Change type of SettingFetcher from interface into abstract class for backward compatibility. See https://github.com/halo-dev/halo/issues/3592 for more.

#### Which issue(s) this PR fixes:

Fixes https://github.com/halo-dev/halo/issues/3592

#### Special notes for your reviewer:

Please use [plugin-search-widget](https://github.com/halo-sigs/plugin-search-widget) to test.

#### Does this PR introduce a user-facing change?

```release-note
None
```
pull/3577/head^2
John Niang 2023-03-27 12:22:10 +08:00 committed by GitHub
parent 1c89638f7e
commit fa7f3c119a
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 10 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
api/src/main/java/run/halo/app/plugin/SettingFetcher.java
View File

@ -4,12 +4,17 @@ import com.fasterxml.jackson.databind.JsonNode;
import java.util.Map; import java.util.Map;
import java.util.Optional; import java.util.Optional;
public interface SettingFetcher { /**
* SettingFetcher must be a class instead of an interface due to backward compatibility.
*
* @author johnniang
*/
public abstract class SettingFetcher {
<T> Optional<T> fetch(String group, Class<T> clazz); public abstract <T> Optional<T> fetch(String group, Class<T> clazz);
JsonNode get(String group); public abstract JsonNode get(String group);
Map<String, JsonNode> getValues(); public abstract Map<String, JsonNode> getValues();
} }

2
application/src/main/java/run/halo/app/plugin/DefaultSettingFetcher.java
View File

@ -21,7 +21,7 @@ import run.halo.app.infra.utils.JsonUtils;
* @author guqing * @author guqing
* @since 2.0.0 * @since 2.0.0
*/ */
public class DefaultSettingFetcher implements SettingFetcher { public class DefaultSettingFetcher extends SettingFetcher {
private final ExtensionClient extensionClient; private final ExtensionClient extensionClient;