github
/
halo
mirror of https://github.com/halo-dev/halo
1
0
Fork 0
Code Issues Releases Wiki Activity

[release-2.14] Cleanup resources when plugin startup fails (#5769) 

Signed-off-by: JohnNiang <johnniang@foxmail.com>
Co-authored-by: JohnNiang <johnniang@foxmail.com>
pull/5772/head
Halo Dev Bot 2024-04-23 11:14:55 +08:00 committed by GitHub
parent ae274db893
commit d8dd043be0
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 34 additions and 23 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

57
application/src/main/java/run/halo/app/plugin/SpringPlugin.java
View File

@ -25,37 +25,47 @@ public class SpringPlugin extends Plugin {
@Override
public void start() {
// initialize context
var pluginId = pluginContext.getName();
this.context = contextFactory.create(pluginId);
try {
// initialize context
var pluginId = pluginContext.getName();
this.context = contextFactory.create(pluginId);
var pluginOpt = context.getBeanProvider(Plugin.class)
.stream()
.findFirst();
context.publishEvent(new SpringPluginStartingEvent(this, this));
if (pluginOpt.isPresent()) {
this.delegate = pluginOpt.get();
if (this.delegate instanceof BasePlugin basePlugin) {
basePlugin.setContext(pluginContext);
var pluginOpt = context.getBeanProvider(Plugin.class)
.stream()
.findFirst();
context.publishEvent(new SpringPluginStartingEvent(this, this));
if (pluginOpt.isPresent()) {
this.delegate = pluginOpt.get();
if (this.delegate instanceof BasePlugin basePlugin) {
basePlugin.setContext(pluginContext);
}
this.delegate.start();
}
this.delegate.start();
context.publishEvent(new SpringPluginStartedEvent(this, this));
} catch (Throwable t) {
// try to stop plugin for cleaning resources if something went wrong
this.stop();
// propagate exception to invoker.
throw t;
}
context.publishEvent(new SpringPluginStartedEvent(this, this));
}
@Override
public void stop() {
if (context != null) {
context.publishEvent(new SpringPluginStoppingEvent(this, this));
try {
if (context != null) {
context.publishEvent(new SpringPluginStoppingEvent(this, this));
}
if (this.delegate != null) {
this.delegate.stop();
}
} finally {
if (context instanceof ConfigurableApplicationContext configurableContext) {
configurableContext.close();
}
// reset application context
context = null;
}
if (this.delegate != null) {
this.delegate.stop();
}
if (context instanceof ConfigurableApplicationContext configurableContext) {
configurableContext.close();
}
// reset application context
context = null;
}
@Override
@ -63,6 +73,7 @@ public class SpringPlugin extends Plugin {
if (delegate != null) {
delegate.delete();
}
this.delegate = null;
}
public ApplicationContext getApplicationContext() {