From a0ea21175c9bc8b8a5579603b932667308c7e3b6 Mon Sep 17 00:00:00 2001 From: John Niang Date: Thu, 16 Nov 2023 16:36:07 +0800 Subject: [PATCH] Revert "ci: push image to GHCR for pull_request event" (#4865) Reverts halo-dev/halo#4588 According to https://docs.github.com/en/actions/security-guides/using-secrets-in-github-actions#using-secrets-in-a-workflow, we cannot obtain secrets in pull requests, so that we are not able to push docker image for every pull request. ```release-note None ``` --- .github/workflows/halo.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/halo.yaml b/.github/workflows/halo.yaml index b4304e2a0..2813bf1e7 100644 --- a/.github/workflows/halo.yaml +++ b/.github/workflows/halo.yaml @@ -72,5 +72,5 @@ jobs: ghcr-token: ${{ secrets.GHCR_TOKEN }} dockerhub-user: ${{ secrets.DOCKER_USERNAME }} dockerhub-token: ${{ secrets.DOCKER_TOKEN }} - push: ${{ github.event_name == 'pull_request' || github.event_name == 'push' || github.event_name == 'release' }} + push: ${{ github.event_name == 'push' || github.event_name == 'release' }} # we only push to GHCR if the push is to the next branch console-ref: ${{ github.event_name == 'release' && github.ref || 'main' }}