From bbc6f23b2df68e92af031fb6282343c0c40d08b6 Mon Sep 17 00:00:00 2001 From: John Niang Date: Mon, 1 Jul 2024 17:25:17 +0800 Subject: [PATCH] Fix the problem of null type of search result (#6241) #### What type of PR is this? /kind bug /area core /milestone 2.17.0 #### What this PR does / why we need it: This PR adds missed type to HaloDocument while converting. #### Which issue(s) this PR fixes: Fixes https://github.com/halo-dev/halo/issues/6235 #### Does this PR introduce a user-facing change? ```release-note None ``` --- .../main/java/run/halo/app/search/lucene/LuceneSearchEngine.java | 1 + .../app/search/lucene/LuceneSearchEngineIntegrationTest.java | 1 + 2 files changed, 2 insertions(+) diff --git a/application/src/main/java/run/halo/app/search/lucene/LuceneSearchEngine.java b/application/src/main/java/run/halo/app/search/lucene/LuceneSearchEngine.java index 294e7a1aa..73559980f 100644 --- a/application/src/main/java/run/halo/app/search/lucene/LuceneSearchEngine.java +++ b/application/src/main/java/run/halo/app/search/lucene/LuceneSearchEngine.java @@ -348,6 +348,7 @@ public class LuceneSearchEngine implements SearchEngine, InitializingBean, Dispo public HaloDocument convert(Document doc) { var haloDoc = new HaloDocument(); haloDoc.setId(doc.get("id")); + haloDoc.setType(doc.get("type")); haloDoc.setMetadataName(doc.get("name")); haloDoc.setTitle(doc.get("title")); haloDoc.setDescription(doc.get("description")); diff --git a/application/src/test/java/run/halo/app/search/lucene/LuceneSearchEngineIntegrationTest.java b/application/src/test/java/run/halo/app/search/lucene/LuceneSearchEngineIntegrationTest.java index c32945fda..91e415235 100644 --- a/application/src/test/java/run/halo/app/search/lucene/LuceneSearchEngineIntegrationTest.java +++ b/application/src/test/java/run/halo/app/search/lucene/LuceneSearchEngineIntegrationTest.java @@ -102,6 +102,7 @@ public class LuceneSearchEngineIntegrationTest { assertEquals(1, hits.size()); var doc = hits.get(0); assertEquals("post.content.halo.run-first-post", doc.getId()); + assertEquals("post.content.halo.run", doc.getType()); assertEquals("first halo post", doc.getTitle()); assertNull(doc.getDescription()); assertEquals("halo", doc.getContent());