github
/
halo
mirror of https://github.com/halo-dev/halo
1
0
Fork 0
Code Issues Releases Wiki Activity

fix: the label of some radio is displayed incorrectly (#3878) 

#### What type of PR is this?

/kind bug
/area console
/milestone 2.6.x

#### What this PR does / why we need it:

修复部分 FormKit 的 radio 表单项的 label 设置不正确的问题。目前影响范围：

1. 使用了 type 为 `menuCheckbox`  `menuRadio` 并将 validation 设置为了 `required`。

![image](https://user-images.githubusercontent.com/21301288/235104292-5324be1d-af48-4c7f-8f31-30a9b3dc9c02.png)

#### Which issue(s) this PR fixes:

Fixes #3876 

#### Does this PR introduce a user-facing change?

```release-note
修复部分 FormKit 的 radio 表单项的 label 设置不正确的问题。
```
pull/3909/head
Ryan Wang 2023-05-04 15:58:39 +08:00 committed by GitHub
parent 3bfecd2b38
commit acceeee59c
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
console/src/formkit/plugins/required-asterisk.ts
View File

@ -1,8 +1,7 @@
import type { FormKitNode } from "@formkit/core"; import type { FormKitNode } from "@formkit/core";
const isCheckboxAndRadioMultiple = (node) => const hasLegendNode = (node) =>
(node.props.type === "checkbox" || node.props.type === "radio") && ["checkbox", "radio", "repeater", "group"].includes(node.props.type);
node.props.options;
export default function requiredAsterisk(node: FormKitNode) { export default function requiredAsterisk(node: FormKitNode) {
node.on("created", () => { node.on("created", () => {
@ -18,7 +17,7 @@ export default function requiredAsterisk(node: FormKitNode) {
); );
if (isRequired) { if (isRequired) {
if (isCheckboxAndRadioMultiple(node)) { if (hasLegendNode(node)) {
sectionsSchema.legend = { sectionsSchema.legend = {
children: ["$label", " *"], children: ["$label", " *"],
}; };