From 8896e16615777a1afff643e8d677e5a0957275d6 Mon Sep 17 00:00:00 2001
From: Ryan Wang <i@ryanc.cc>
Date: Fri, 4 Oct 2024 22:10:44 +0800
Subject: [PATCH] feat: disallow deletion of system-protected attachment
 policies (#6735)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

#### What type of PR is this?

/area core
/kind improvement
/milestone 2.20.x

#### What this PR does / why we need it:

为系统默认的存储策略添加保护措施，不允许删除。

<img width="893" alt="image" src="https://github.com/user-attachments/assets/990f834f-3d97-4ee8-9c24-01cc188b7be6">


#### Does this PR introduce a user-facing change?

```release-note
为系统默认的存储策略添加保护措施，不允许删除。
```
---
 .../extensions/attachment-local-policy.yaml   |  2 ++
 .../components/AttachmentPoliciesModal.vue    | 25 +++++++++++++++++--
 ui/src/constants/finalizers.ts                |  1 +
 ui/src/locales/en.yaml                        |  1 +
 ui/src/locales/zh-CN.yaml                     |  1 +
 ui/src/locales/zh-TW.yaml                     |  1 +
 6 files changed, 29 insertions(+), 2 deletions(-)
 create mode 100644 ui/src/constants/finalizers.ts

diff --git a/application/src/main/resources/extensions/attachment-local-policy.yaml b/application/src/main/resources/extensions/attachment-local-policy.yaml
index faba8b06f..645895d28 100644
--- a/application/src/main/resources/extensions/attachment-local-policy.yaml
+++ b/application/src/main/resources/extensions/attachment-local-policy.yaml
@@ -10,6 +10,8 @@ apiVersion: storage.halo.run/v1alpha1
 kind: Policy
 metadata:
   name: default-policy
+  finalizers:
+    - system-protection
 spec:
   displayName: 本地存储
   templateName: local
diff --git a/ui/console-src/modules/contents/attachments/components/AttachmentPoliciesModal.vue b/ui/console-src/modules/contents/attachments/components/AttachmentPoliciesModal.vue
index 3b4b5ae39..a7c036a1c 100644
--- a/ui/console-src/modules/contents/attachments/components/AttachmentPoliciesModal.vue
+++ b/ui/console-src/modules/contents/attachments/components/AttachmentPoliciesModal.vue
@@ -1,4 +1,5 @@
 <script lang="ts" setup>
+import { SYSTEM_PROTECTION } from "@/constants/finalizers";
 import { formatDatetime } from "@/utils/date";
 import type { Policy, PolicyTemplate } from "@halo-dev/api-client";
 import { consoleApiClient, coreApiClient } from "@halo-dev/api-client";
@@ -15,6 +16,7 @@ import {
   VModal,
   VSpace,
   VStatusDot,
+  VTag,
 } from "@halo-dev/components";
 import { ref } from "vue";
 import { useI18n } from "vue-i18n";
@@ -171,6 +173,14 @@ function getPolicyTemplateDisplayName(templateName: string) {
             ></VEntityField>
           </template>
           <template #end>
+            <VEntityField>
+              <template
+                v-if="policy.metadata.finalizers?.includes(SYSTEM_PROTECTION)"
+                #description
+              >
+                <VTag>{{ $t("core.common.text.system_protection") }}</VTag>
+              </template>
+            </VEntityField>
             <VEntityField v-if="policy.metadata.deletionTimestamp">
               <template #description>
                 <VStatusDot
@@ -189,10 +199,21 @@ function getPolicyTemplateDisplayName(templateName: string) {
             </VEntityField>
           </template>
           <template #dropdownItems>
-            <VDropdownItem @click="handleOpenEditingModal(policy)">
+            <VDropdownItem
+              :disabled="
+                policy.metadata.finalizers?.includes(SYSTEM_PROTECTION)
+              "
+              @click="handleOpenEditingModal(policy)"
+            >
               {{ $t("core.common.buttons.edit") }}
             </VDropdownItem>
-            <VDropdownItem type="danger" @click="handleDelete(policy)">
+            <VDropdownItem
+              :disabled="
+                policy.metadata.finalizers?.includes(SYSTEM_PROTECTION)
+              "
+              type="danger"
+              @click="handleDelete(policy)"
+            >
               {{ $t("core.common.buttons.delete") }}
             </VDropdownItem>
           </template>
diff --git a/ui/src/constants/finalizers.ts b/ui/src/constants/finalizers.ts
new file mode 100644
index 000000000..5e8ad3ca7
--- /dev/null
+++ b/ui/src/constants/finalizers.ts
@@ -0,0 +1 @@
+export const SYSTEM_PROTECTION = "system-protection";
diff --git a/ui/src/locales/en.yaml b/ui/src/locales/en.yaml
index 2ae761371..8250ab3ac 100644
--- a/ui/src/locales/en.yaml
+++ b/ui/src/locales/en.yaml
@@ -1779,6 +1779,7 @@ core:
       none: None
       tip: Tip
       warning: Warning
+      system_protection: System protection
     tooltips:
       unpublished_content_tip: There is content that has been saved but not yet published.
       publishing: Publishing
diff --git a/ui/src/locales/zh-CN.yaml b/ui/src/locales/zh-CN.yaml
index 92783f828..7480986aa 100644
--- a/ui/src/locales/zh-CN.yaml
+++ b/ui/src/locales/zh-CN.yaml
@@ -1664,6 +1664,7 @@ core:
       none: 无
       tip: 提示
       warning: 警告
+      system_protection: 系统保留
     tooltips:
       unpublished_content_tip: 当前有内容已保存，但还未发布。
       publishing: 发布中
diff --git a/ui/src/locales/zh-TW.yaml b/ui/src/locales/zh-TW.yaml
index 3c8233971..a68bac96b 100644
--- a/ui/src/locales/zh-TW.yaml
+++ b/ui/src/locales/zh-TW.yaml
@@ -1645,6 +1645,7 @@ core:
       none: 無
       tip: 提示
       warning: 警告
+      system_protection: 系統保留
     tooltips:
       unpublished_content_tip: 當前有內容已保存，但還未發布。
       publishing: 發布中