github
/
halo
mirror of https://github.com/halo-dev/halo
1
0
Fork 0
Code Issues Releases Wiki Activity

Fix the problem of slug name with percent sign when publishing post (#3179) 

#### What type of PR is this?

/kind bug
/area core
/milestone 2.2.x

#### What this PR does / why we need it:

Remove URI decode operation while inserting key into RadixRouterTree to avoid repeat decode.

#### Which issue(s) this PR fixes:

Fixes #3178 

#### Special notes for your reviewer:

1. Set slug name to `1%1` when creating a post
2. Publish it
3. Browse the post

#### Does this PR introduce a user-facing change?

```release-note
修复因别名包含百分号导致无法正常访问的问题
```
pull/3168/head^2
John Niang 2023-01-30 11:16:11 +08:00 committed by GitHub
parent ca4e93d4bb
commit 7188464bc1
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 8 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/main/java/run/halo/app/theme/router/RadixRouterTree.java
View File

@ -31,9 +31,7 @@ public class RadixRouterTree extends RadixTree<HandlerFunction<ServerResponse>>
@Override @Override
public void insert(String key, HandlerFunction<ServerResponse> value) public void insert(String key, HandlerFunction<ServerResponse> value)
throws IllegalArgumentException { throws IllegalArgumentException {
// uri decode key to insert super.insert(key, value);
String decodedKey = UriUtils.decode(key, StandardCharsets.UTF_8);
super.insert(decodedKey, value);
if (log.isDebugEnabled()) { if (log.isDebugEnabled()) {
checkIndices(); checkIndices();
} }

7
src/test/java/run/halo/app/theme/router/RadixRouterTreeTest.java
View File

@ -7,6 +7,7 @@ import java.net.URISyntaxException;
import org.junit.jupiter.api.Test; import org.junit.jupiter.api.Test;
import org.springframework.http.HttpMethod; import org.springframework.http.HttpMethod;
import org.springframework.mock.web.reactive.function.server.MockServerRequest; import org.springframework.mock.web.reactive.function.server.MockServerRequest;
import org.springframework.web.reactive.function.server.ServerResponse;
/** /**
* Tests for {@link RadixRouterTree}. * Tests for {@link RadixRouterTree}.
@ -41,4 +42,10 @@ class RadixRouterTreeTest {
.method(HttpMethod.GET).build(); .method(HttpMethod.GET).build();
assertThat(RadixRouterTree.pathToFind(request)).isEqualTo("/?p=fake-post"); assertThat(RadixRouterTree.pathToFind(request)).isEqualTo("/?p=fake-post");
} }
@Test
void shouldInsertKeyWithPercentSign() {
var tree = new RadixRouterTree();
tree.insert("/1%1", request -> ServerResponse.ok().build());
}
} }