diff --git a/application/src/main/java/run/halo/app/content/AbstractContentService.java b/application/src/main/java/run/halo/app/content/AbstractContentService.java index 17873479b..ea3add8d4 100644 --- a/application/src/main/java/run/halo/app/content/AbstractContentService.java +++ b/application/src/main/java/run/halo/app/content/AbstractContentService.java @@ -4,6 +4,7 @@ import java.security.Principal; import java.time.Instant; import java.util.UUID; import lombok.AllArgsConstructor; +import lombok.extern.slf4j.Slf4j; import org.apache.commons.lang3.StringUtils; import org.springframework.lang.Nullable; import org.springframework.security.core.context.ReactiveSecurityContextHolder; @@ -20,22 +21,32 @@ import run.halo.app.extension.ReactiveExtensionClient; * @author guqing * @since 2.0.0 */ +@Slf4j @AllArgsConstructor public abstract class AbstractContentService { private final ReactiveExtensionClient client; public Mono getContent(String snapshotName, String baseSnapshotName) { - return client.get(Snapshot.class, baseSnapshotName) + if (StringUtils.isBlank(snapshotName) || StringUtils.isBlank(baseSnapshotName)) { + return Mono.empty(); + } + // TODO: refactor this method to use client.get instead of fetch but please be careful + return client.fetch(Snapshot.class, baseSnapshotName) .doOnNext(this::checkBaseSnapshot) .flatMap(baseSnapshot -> { if (StringUtils.equals(snapshotName, baseSnapshotName)) { var contentWrapper = ContentWrapper.patchSnapshot(baseSnapshot, baseSnapshot); return Mono.just(contentWrapper); } - return client.get(Snapshot.class, snapshotName) + return client.fetch(Snapshot.class, snapshotName) .map(snapshot -> ContentWrapper.patchSnapshot(snapshot, baseSnapshot)); - }); + }) + .switchIfEmpty(Mono.defer(() -> { + log.error("The content snapshot [{}] or base snapshot [{}] not found.", + snapshotName, baseSnapshotName); + return Mono.empty(); + })); } protected void checkBaseSnapshot(Snapshot snapshot) { diff --git a/application/src/main/java/run/halo/app/theme/router/PreviewRouterFunction.java b/application/src/main/java/run/halo/app/theme/router/PreviewRouterFunction.java index f60342cd5..56b149c4c 100644 --- a/application/src/main/java/run/halo/app/theme/router/PreviewRouterFunction.java +++ b/application/src/main/java/run/halo/app/theme/router/PreviewRouterFunction.java @@ -70,7 +70,7 @@ public class PreviewRouterFunction { .flatMap(post -> canPreview(post.getContributors()) .doOnNext(canPreview -> { if (!canPreview) { - throw new NotFoundException("Page not found."); + throw new NotFoundException("Post not found."); } }) .thenReturn(post) @@ -138,7 +138,7 @@ public class PreviewRouterFunction { .flatMap(singlePageVo -> canPreview(singlePageVo.getContributors()) .doOnNext(canPreview -> { if (!canPreview) { - throw new NotFoundException("Page not found."); + throw new NotFoundException("Single page not found."); } }) .thenReturn(singlePageVo)