From 4eb205ba661ab0df87a986c68e00c79dd23d1c15 Mon Sep 17 00:00:00 2001
From: Halo Dev Bot <87291978+halo-dev-bot@users.noreply.github.com>
Date: Tue, 23 Apr 2024 14:40:53 +0800
Subject: [PATCH] [release-2.14] fix: the details of the attachment may be
 empty (#5774)

* fix: the details of the attachment may be empty

* fix: the details of the attachment may be empty

---------

Co-authored-by: LIlGG <1103069291@qq.com>
---
 .../contents/attachments/AttachmentList.vue   |  3 ++-
 .../components/AttachmentDetailModal.vue      | 19 ++-----------------
 2 files changed, 4 insertions(+), 18 deletions(-)

diff --git a/ui/console-src/modules/contents/attachments/AttachmentList.vue b/ui/console-src/modules/contents/attachments/AttachmentList.vue
index 213ae0eea..63317740a 100644
--- a/ui/console-src/modules/contents/attachments/AttachmentList.vue
+++ b/ui/console-src/modules/contents/attachments/AttachmentList.vue
@@ -166,6 +166,7 @@ const onDetailModalClose = () => {
   selectedAttachment.value = undefined;
   nameQuery.value = undefined;
   nameQueryAttachment.value = undefined;
+  detailVisible.value = false;
   handleFetchAttachments();
 };
 
@@ -230,7 +231,7 @@ onMounted(() => {
 </script>
 <template>
   <AttachmentDetailModal
-    v-model:visible="detailVisible"
+    v-if="detailVisible"
     :attachment="selectedAttachment || nameQueryAttachment"
     @close="onDetailModalClose"
   >
diff --git a/ui/console-src/modules/contents/attachments/components/AttachmentDetailModal.vue b/ui/console-src/modules/contents/attachments/components/AttachmentDetailModal.vue
index fbc4a0eb2..ffd92093c 100644
--- a/ui/console-src/modules/contents/attachments/components/AttachmentDetailModal.vue
+++ b/ui/console-src/modules/contents/attachments/components/AttachmentDetailModal.vue
@@ -19,19 +19,16 @@ import AttachmentPermalinkList from "./AttachmentPermalinkList.vue";
 
 const props = withDefaults(
   defineProps<{
-    visible: boolean;
     attachment: Attachment | undefined;
     mountToBody?: boolean;
   }>(),
   {
-    visible: false,
     attachment: undefined,
     mountToBody: false,
   }
 );
 
 const emit = defineEmits<{
-  (event: "update:visible", visible: boolean): void;
   (event: "close"): void;
 }>();
 
@@ -64,17 +61,6 @@ const getGroupName = (name: string | undefined) => {
   const group = groups.value?.find((group) => group.metadata.name === name);
   return group?.spec.displayName || name;
 };
-
-const onVisibleChange = (visible: boolean) => {
-  emit("update:visible", visible);
-  if (!visible) {
-    onlyPreview.value = false;
-
-    setTimeout(() => {
-      emit("close");
-    }, 200);
-  }
-};
 </script>
 <template>
   <VModal
@@ -83,13 +69,12 @@ const onVisibleChange = (visible: boolean) => {
         display_name: attachment?.spec.displayName || '',
       })
     "
-    :visible="visible"
     :width="1000"
     :mount-to-body="mountToBody"
     :layer-closable="true"
     height="calc(100vh - 20px)"
     :body-class="['!p-0']"
-    @update:visible="onVisibleChange"
+    @close="emit('close')"
   >
     <template #actions>
       <slot name="actions"></slot>
@@ -198,7 +183,7 @@ const onVisibleChange = (visible: boolean) => {
     </div>
     <template #footer>
       <VSpace>
-        <VButton type="default" @click="onVisibleChange(false)">
+        <VButton type="default" @click="emit('close')">
           {{ $t("core.common.buttons.close_and_shortcut") }}
         </VButton>
         <slot name="footer" />