github
/
halo
mirror of https://github.com/halo-dev/halo
1
0
Fork 0
Code Issues Releases Wiki Activity

Fix existence check of posts in some cases (#7673) 

#### What type of PR is this?

/kind bug
/area core
/milestone 2.21.x

#### What this PR does / why we need it:

This PR fixes the internal check of selector converter `NotEquals`, which might lead to failing check of `metadata.name!=1`.

#### Which issue(s) this PR fixes:

Fixes https://github.com/halo-dev/halo/issues/7666

#### Does this PR introduce a user-facing change?

```release-note
修复极端场景下无法检查文章别名是否存在的问题
```
pull/7677/head
John Niang 2025-08-08 19:22:40 +08:00 committed by GitHub
parent 576dda9d74
commit 17643bc451
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 7 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
api/src/main/java/run/halo/app/extension/router/selector/Operator.java
View File

@ -44,7 +44,7 @@ public enum Operator implements Converter<String, SelectorCriteria> {
public SelectorCriteria convert(@Nullable String selector) {
if (preFlightCheck(selector, 4)) {
var i = selector.indexOf(getOperator());
if (i > 0 && (i + getOperator().length()) < selector.length() - 1) {
if (i > 0 && (i + getOperator().length()) < selector.length()) {
String key = selector.substring(0, i);
String value = selector.substring(i + getOperator().length());
return new SelectorCriteria(key, this, Set.of(value));

7
api/src/test/java/run/halo/app/extension/router/selector/OperatorTest.java
View File

@ -27,7 +27,7 @@ class OperatorTest {
new TestCase("name=", Equals, null),
new TestCase("name=value", Equals,
new SelectorCriteria("name", Equals, Set.of("value"))),
new TestCase("name=v", Equals,
new TestCase("name=v", Equals,
new SelectorCriteria("name", Equals, Set.of("v"))),
new TestCase("", NotEquals, null),
@ -45,6 +45,10 @@ class OperatorTest {
new TestCase("name", NotExist, null),
new TestCase("na!me", NotExist, null),
new TestCase("name!", NotExist, null),
new TestCase("name!=1", NotEquals,
new SelectorCriteria("name", NotEquals, Set.of("1"))),
new TestCase("name!=12", NotEquals,
new SelectorCriteria("name", NotEquals, Set.of("12"))),
new TestCase("name", Exist, new SelectorCriteria("name", Exist, Set.of())),
new TestCase("", Exist, null),
@ -61,4 +65,5 @@ class OperatorTest {
assertEquals(testCase.expected(), testCase.converter().convert(testCase.source()));
});
}
}