github
/
halo
mirror of https://github.com/halo-dev/halo
1
0
Fork 0
Code Issues Releases Wiki Activity

fix: language preference is not remembered under non-HTTPS connections (#6891) 

#### What type of PR is this?
/kind bug
/area core
/milestone 2.20.x

#### What this PR does / why we need it:
修复非 HTTPS 连接下无法记住用户语言偏好的问题

#### Which issue(s) this PR fixes:
Fixes #6888

#### Does this PR introduce a user-facing change?
```release-note
修复非 HTTPS 连接下无法记住用户语言偏好的问题
```
pull/6902/head
guqing 2024-10-18 17:47:37 +08:00 committed by GitHub
parent 3570353ce2
commit 13644d21eb
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 10 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
application/src/main/java/run/halo/app/infra/webfilter/LocaleChangeWebFilter.java
View File

@ -45,15 +45,19 @@ public class LocaleChangeWebFilter implements WebFilter {
.getFirst(LANGUAGE_PARAMETER_NAME);
if (StringUtils.hasText(language)) {
var locale = Locale.forLanguageTag(language);
exchange.getResponse()
.addCookie(ResponseCookie.from(LANGUAGE_COOKIE_NAME, locale.toLanguageTag())
.path("/")
.secure(true)
.build()
);
setLanguageCookie(exchange, locale);
}
})
.then(Mono.defer(() -> chain.filter(exchange)));
}
void setLanguageCookie(ServerWebExchange exchange, Locale locale) {
var cookie = ResponseCookie.from(LANGUAGE_COOKIE_NAME, locale.toLanguageTag())
.path("/")
.httpOnly(true)
.secure("https".equalsIgnoreCase(exchange.getRequest().getURI().getScheme()))
.sameSite("Lax")
.build();
exchange.getResponse().getCookies().set(LANGUAGE_COOKIE_NAME, cookie);
}
}