From 022526386acbce5f998fd2979d759241eca155ea Mon Sep 17 00:00:00 2001 From: Ryan Wang Date: Wed, 19 Jul 2023 11:44:12 +0800 Subject: [PATCH] perf: improve polling interval for api requests (#4246) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit #### What type of PR is this? /area console /kind improvement /milestone 2.8.x #### What this PR does / why we need it: 优化 Console 端对异步数据轮询的间隔时间 #### Which issue(s) this PR fixes: Fixes https://github.com/halo-dev/halo/issues/4214 #### Does this PR introduce a user-facing change? ```release-note 优化 Console 端对异步数据轮询的间隔时间 ``` --- .../modules/contents/attachments/composables/use-attachment.ts | 2 +- console/src/modules/contents/comments/CommentList.vue | 2 +- .../modules/contents/comments/components/CommentListItem.vue | 2 +- console/src/modules/contents/pages/DeletedSinglePageList.vue | 2 +- console/src/modules/contents/pages/SinglePageList.vue | 2 +- console/src/modules/contents/posts/DeletedPostList.vue | 2 +- console/src/modules/contents/posts/PostList.vue | 2 +- .../contents/posts/categories/composables/use-post-category.ts | 2 +- .../src/modules/contents/posts/tags/composables/use-post-tag.ts | 2 +- console/src/modules/interface/menus/Menus.vue | 2 +- console/src/modules/interface/menus/components/MenuList.vue | 2 +- .../src/modules/interface/themes/components/ThemeListModal.vue | 2 +- console/src/modules/system/plugins/PluginList.vue | 2 +- console/src/modules/system/roles/composables/use-role.ts | 2 +- console/src/modules/system/users/UserList.vue | 2 +- 15 files changed, 15 insertions(+), 15 deletions(-) diff --git a/console/src/modules/contents/attachments/composables/use-attachment.ts b/console/src/modules/contents/attachments/composables/use-attachment.ts index 02e19fda0..ce96a57d0 100644 --- a/console/src/modules/contents/attachments/composables/use-attachment.ts +++ b/console/src/modules/contents/attachments/composables/use-attachment.ts @@ -78,7 +78,7 @@ export function useAttachmentControl(filterOptions: { const deletingAttachments = data?.filter( (attachment) => !!attachment.metadata.deletionTimestamp ); - return deletingAttachments?.length ? 3000 : false; + return deletingAttachments?.length ? 1000 : false; }, }); diff --git a/console/src/modules/contents/comments/CommentList.vue b/console/src/modules/contents/comments/CommentList.vue index e538cc85e..df615c1ac 100644 --- a/console/src/modules/contents/comments/CommentList.vue +++ b/console/src/modules/contents/comments/CommentList.vue @@ -94,7 +94,7 @@ const { const deletingComments = data?.filter( (comment) => !!comment.comment.metadata.deletionTimestamp ); - return deletingComments?.length ? 3000 : false; + return deletingComments?.length ? 1000 : false; }, }); diff --git a/console/src/modules/contents/comments/components/CommentListItem.vue b/console/src/modules/contents/comments/components/CommentListItem.vue index 9caa6c37a..8b86e7dc9 100644 --- a/console/src/modules/contents/comments/components/CommentListItem.vue +++ b/console/src/modules/contents/comments/components/CommentListItem.vue @@ -162,7 +162,7 @@ const { const deletingReplies = data?.filter( (reply) => !!reply.reply.metadata.deletionTimestamp ); - return deletingReplies?.length ? 3000 : false; + return deletingReplies?.length ? 1000 : false; }, enabled: computed(() => showReplies.value), }); diff --git a/console/src/modules/contents/pages/DeletedSinglePageList.vue b/console/src/modules/contents/pages/DeletedSinglePageList.vue index fa5c3cdd9..d59d03a6b 100644 --- a/console/src/modules/contents/pages/DeletedSinglePageList.vue +++ b/console/src/modules/contents/pages/DeletedSinglePageList.vue @@ -64,7 +64,7 @@ const { !!singlePage.page.metadata.deletionTimestamp || !singlePage.page.spec.deleted ); - return deletedSinglePages?.length ? 3000 : false; + return deletedSinglePages?.length ? 1000 : false; }, }); diff --git a/console/src/modules/contents/pages/SinglePageList.vue b/console/src/modules/contents/pages/SinglePageList.vue index e5df4afb7..faf50675a 100644 --- a/console/src/modules/contents/pages/SinglePageList.vue +++ b/console/src/modules/contents/pages/SinglePageList.vue @@ -143,7 +143,7 @@ const { (spec.releaseSnapshot === spec.headSnapshot && status?.inProgress) ); }); - return abnormalSinglePages?.length ? 3000 : false; + return abnormalSinglePages?.length ? 1000 : false; }, }); diff --git a/console/src/modules/contents/posts/DeletedPostList.vue b/console/src/modules/contents/posts/DeletedPostList.vue index 7c8a6dbd9..cc3d25ea1 100644 --- a/console/src/modules/contents/posts/DeletedPostList.vue +++ b/console/src/modules/contents/posts/DeletedPostList.vue @@ -63,7 +63,7 @@ const { (post) => !!post.post.metadata.deletionTimestamp || !post.post.spec.deleted ); - return deletingPosts?.length ? 3000 : false; + return deletingPosts?.length ? 1000 : false; }, }); diff --git a/console/src/modules/contents/posts/PostList.vue b/console/src/modules/contents/posts/PostList.vue index 697e9f1e5..8199f4bf2 100644 --- a/console/src/modules/contents/posts/PostList.vue +++ b/console/src/modules/contents/posts/PostList.vue @@ -172,7 +172,7 @@ const { ); }); - return abnormalPosts?.length ? 3000 : false; + return abnormalPosts?.length ? 1000 : false; }, }); diff --git a/console/src/modules/contents/posts/categories/composables/use-post-category.ts b/console/src/modules/contents/posts/categories/composables/use-post-category.ts index 676b1aded..0e8d90c26 100644 --- a/console/src/modules/contents/posts/categories/composables/use-post-category.ts +++ b/console/src/modules/contents/posts/categories/composables/use-post-category.ts @@ -41,7 +41,7 @@ export function usePostCategory(): usePostCategoryReturn { (category) => !!category.metadata.deletionTimestamp || !category.status?.permalink ); - return abnormalCategories?.length ? 3000 : false; + return abnormalCategories?.length ? 1000 : false; }, onSuccess(data) { categoriesTree.value = buildCategoriesTree(data); diff --git a/console/src/modules/contents/posts/tags/composables/use-post-tag.ts b/console/src/modules/contents/posts/tags/composables/use-post-tag.ts index 1a28421bf..11c4f8a81 100644 --- a/console/src/modules/contents/posts/tags/composables/use-post-tag.ts +++ b/console/src/modules/contents/posts/tags/composables/use-post-tag.ts @@ -34,7 +34,7 @@ export function usePostTag(): usePostTagReturn { const abnormalTags = data?.filter( (tag) => !!tag.metadata.deletionTimestamp || !tag.status?.permalink ); - return abnormalTags?.length ? 3000 : false; + return abnormalTags?.length ? 1000 : false; }, }); diff --git a/console/src/modules/interface/menus/Menus.vue b/console/src/modules/interface/menus/Menus.vue index 0a462c611..060ec9c55 100644 --- a/console/src/modules/interface/menus/Menus.vue +++ b/console/src/modules/interface/menus/Menus.vue @@ -66,7 +66,7 @@ const { const deletingMenuItems = data?.filter( (menuItem) => !!menuItem.metadata.deletionTimestamp ); - return deletingMenuItems?.length ? 3000 : false; + return deletingMenuItems?.length ? 1000 : false; }, enabled: computed(() => !!selectedMenu.value), }); diff --git a/console/src/modules/interface/menus/components/MenuList.vue b/console/src/modules/interface/menus/components/MenuList.vue index 1069c4631..043712fb4 100644 --- a/console/src/modules/interface/menus/components/MenuList.vue +++ b/console/src/modules/interface/menus/components/MenuList.vue @@ -69,7 +69,7 @@ const { const deletingMenus = data?.filter( (menu) => !!menu.metadata.deletionTimestamp ); - return deletingMenus?.length ? 3000 : false; + return deletingMenus?.length ? 1000 : false; }, }); diff --git a/console/src/modules/interface/themes/components/ThemeListModal.vue b/console/src/modules/interface/themes/components/ThemeListModal.vue index 099a555ea..759c34827 100644 --- a/console/src/modules/interface/themes/components/ThemeListModal.vue +++ b/console/src/modules/interface/themes/components/ThemeListModal.vue @@ -78,7 +78,7 @@ const { (theme) => !!theme.metadata.deletionTimestamp ); - return deletingThemes?.length ? 3000 : false; + return deletingThemes?.length ? 1000 : false; }, enabled: computed(() => props.visible), }); diff --git a/console/src/modules/system/plugins/PluginList.vue b/console/src/modules/system/plugins/PluginList.vue index 4ca8a828d..dcbcd8a70 100644 --- a/console/src/modules/system/plugins/PluginList.vue +++ b/console/src/modules/system/plugins/PluginList.vue @@ -81,7 +81,7 @@ const { data, isLoading, isFetching, refetch } = useQuery({ (plugin) => !!plugin.metadata.deletionTimestamp ); - return deletingPlugins?.length ? 3000 : false; + return deletingPlugins?.length ? 2000 : false; }, }); diff --git a/console/src/modules/system/roles/composables/use-role.ts b/console/src/modules/system/roles/composables/use-role.ts index b05619576..4b8d643ab 100644 --- a/console/src/modules/system/roles/composables/use-role.ts +++ b/console/src/modules/system/roles/composables/use-role.ts @@ -80,7 +80,7 @@ export function useFetchRole(): useFetchRoleReturn { if (deletedRoles.length) { refreshInterval.value = setInterval(() => { handleFetchRoles({ mute: true }); - }, 3000); + }, 1000); } } catch (e) { console.error("Failed to fetch roles", e); diff --git a/console/src/modules/system/users/UserList.vue b/console/src/modules/system/users/UserList.vue index bdfd66a7d..ca5e62ce6 100644 --- a/console/src/modules/system/users/UserList.vue +++ b/console/src/modules/system/users/UserList.vue @@ -116,7 +116,7 @@ const { (user) => !!user.user.metadata.deletionTimestamp ); - return deletingUsers?.length ? 3000 : false; + return deletingUsers?.length ? 1000 : false; }, onSuccess() { selectedUser.value = undefined;