From f14f24cf8c6ffd8c7ff07649b2123518df8084b8 Mon Sep 17 00:00:00 2001
From: Ryan Wang <i@ryanc.cc>
Date: Tue, 30 Aug 2022 17:30:43 +0800
Subject: [PATCH] chore: use vue/vue3-recommended eslint plugin

Signed-off-by: Ryan Wang <i@ryanc.cc>
---
 .eslintrc.cjs                                          |  2 +-
 packages/components/package.json                       |  3 +--
 packages/components/src/components/alert/Alert.vue     |  2 ++
 packages/components/src/components/button/Button.vue   |  3 ++-
 .../components/src/components/checkbox/CheckBox.vue    |  9 ++++++---
 .../src/components/checkbox/CheckBoxGroup.vue          |  3 ++-
 .../__tests__/__snapshots__/CheckBox.spec.ts.snap      |  2 +-
 .../src/components/codemirror/Codemirror.story.vue     |  2 +-
 packages/components/src/components/dialog/Dialog.vue   |  6 ++++++
 .../src/components/dialog/DialogProvider.vue           |  4 ++--
 packages/components/src/components/input/Input.vue     |  2 ++
 packages/components/src/components/menu/RoutesMenu.tsx |  1 +
 packages/components/src/components/modal/Modal.vue     |  2 ++
 .../src/components/pagination/Pagination.vue           |  2 +-
 .../components/src/components/radio/RadioGroup.vue     |  3 +++
 packages/components/src/components/select/Select.vue   |  2 ++
 packages/components/src/components/tabs/Tabbar.vue     |  2 ++
 packages/components/src/components/tabs/Tabs.vue       |  3 ++-
 .../components/src/components/textarea/Textarea.vue    |  2 ++
 packages/shared/package.json                           |  4 +++-
 .../attachments/components/AttachmentUploadModal.vue   |  2 +-
 src/modules/contents/posts/PostList.vue                | 10 +++++-----
 .../contents/posts/components/PostPreviewModal.vue     |  2 +-
 src/modules/dashboard/widgets/JournalPublishWidget.vue |  2 +-
 src/modules/dashboard/widgets/QuickLinkWidget.vue      |  2 +-
 src/modules/dashboard/widgets/RecentLoginWidget.vue    |  2 +-
 .../dashboard/widgets/RecentPublishedWidget.vue        |  2 +-
 src/modules/interface/menus/components/MenuList.vue    |  2 +-
 .../system/roles/components/RoleEditingModal.vue       | 10 +++++-----
 src/modules/system/users/UserList.vue                  |  6 +++---
 30 files changed, 64 insertions(+), 35 deletions(-)

diff --git a/.eslintrc.cjs b/.eslintrc.cjs
index 24ffd5bd..8bd5f6fa 100644
--- a/.eslintrc.cjs
+++ b/.eslintrc.cjs
@@ -4,7 +4,7 @@ require("@rushstack/eslint-patch/modern-module-resolution");
 module.exports = {
   root: true,
   extends: [
-    "plugin:vue/vue3-essential",
+    "plugin:vue/vue3-recommended",
     "eslint:recommended",
     "@vue/eslint-config-typescript/recommended",
     "@vue/eslint-config-prettier",
diff --git a/packages/components/package.json b/packages/components/package.json
index fde40d1a..37062b93 100644
--- a/packages/components/package.json
+++ b/packages/components/package.json
@@ -21,8 +21,7 @@
     "story:dev": "histoire dev --port 4000",
     "story:build": "histoire build",
     "lint": "eslint ./src --ext .vue,.js,.jsx,.cjs,.mjs,.ts,.tsx,.cts,.mts",
-    "prettier": "prettier --write './src/**/*.{vue,js,jsx,ts,tsx,css,scss,json,yml,yaml,html}'",
-    "test": "echo \"Error: no test specified\" && exit 1"
+    "prettier": "prettier --write './src/**/*.{vue,js,jsx,ts,tsx,css,scss,json,yml,yaml,html}'"
   },
   "keywords": [
     "halo",
diff --git a/packages/components/src/components/alert/Alert.vue b/packages/components/src/components/alert/Alert.vue
index 63a6cf27..06efd9e2 100644
--- a/packages/components/src/components/alert/Alert.vue
+++ b/packages/components/src/components/alert/Alert.vue
@@ -27,6 +27,8 @@ const props = withDefaults(
   }>(),
   {
     type: "default",
+    title: "",
+    description: "",
     closable: true,
   }
 );
diff --git a/packages/components/src/components/button/Button.vue b/packages/components/src/components/button/Button.vue
index 7221d345..7945c8ef 100644
--- a/packages/components/src/components/button/Button.vue
+++ b/packages/components/src/components/button/Button.vue
@@ -48,7 +48,7 @@ const props = withDefaults(
     block?: boolean;
     disabled?: boolean;
     loading?: boolean;
-    route?: RouteLocationRaw;
+    route?: RouteLocationRaw | undefined;
   }>(),
   {
     type: "default",
@@ -57,6 +57,7 @@ const props = withDefaults(
     block: false,
     disabled: false,
     loading: false,
+    route: undefined,
   }
 );
 
diff --git a/packages/components/src/components/checkbox/CheckBox.vue b/packages/components/src/components/checkbox/CheckBox.vue
index 6fba8e9c..4ac35a6d 100644
--- a/packages/components/src/components/checkbox/CheckBox.vue
+++ b/packages/components/src/components/checkbox/CheckBox.vue
@@ -2,12 +2,15 @@
 const props = withDefaults(
   defineProps<{
     checked?: boolean;
-    value?: string | number | boolean;
-    label?: string;
-    name?: string;
+    value?: string | number | boolean | undefined;
+    label?: string | undefined;
+    name?: string | undefined;
   }>(),
   {
     checked: false,
+    value: undefined,
+    label: undefined,
+    name: undefined,
   }
 );
 
diff --git a/packages/components/src/components/checkbox/CheckBoxGroup.vue b/packages/components/src/components/checkbox/CheckBoxGroup.vue
index 27a411df..0e99a900 100644
--- a/packages/components/src/components/checkbox/CheckBoxGroup.vue
+++ b/packages/components/src/components/checkbox/CheckBoxGroup.vue
@@ -4,7 +4,7 @@ import { VCheckbox } from "./index";
 const props = withDefaults(
   defineProps<{
     modelValue?: string[];
-    options?: Array<Record<string, string>>;
+    options: Array<Record<string, string>>;
     valueKey?: string;
     labelKey?: string;
     name?: string;
@@ -13,6 +13,7 @@ const props = withDefaults(
     modelValue: () => [],
     valueKey: "value",
     labelKey: "label",
+    name: undefined,
   }
 );
 
diff --git a/packages/components/src/components/checkbox/__tests__/__snapshots__/CheckBox.spec.ts.snap b/packages/components/src/components/checkbox/__tests__/__snapshots__/CheckBox.spec.ts.snap
index 8aaef497..06e654d5 100644
--- a/packages/components/src/components/checkbox/__tests__/__snapshots__/CheckBox.spec.ts.snap
+++ b/packages/components/src/components/checkbox/__tests__/__snapshots__/CheckBox.spec.ts.snap
@@ -2,7 +2,7 @@
 
 exports[`CheckBox > should render 1`] = `
 "<div class=\\"checkbox-wrapper\\">
-  <div class=\\"checkbox-inner\\"><input id=\\"checkbox\\" type=\\"checkbox\\" value=\\"false\\"></div>
+  <div class=\\"checkbox-inner\\"><input id=\\"checkbox\\" type=\\"checkbox\\"></div>
   <!--v-if-->
 </div>"
 `;
diff --git a/packages/components/src/components/codemirror/Codemirror.story.vue b/packages/components/src/components/codemirror/Codemirror.story.vue
index b21488d7..a1f079e6 100644
--- a/packages/components/src/components/codemirror/Codemirror.story.vue
+++ b/packages/components/src/components/codemirror/Codemirror.story.vue
@@ -8,7 +8,7 @@ function initState() {
 }
 </script>
 <template>
-  <Story :initState="initState" title="Codemirror">
+  <Story :init-state="initState" title="Codemirror">
     <template #default="{ state }">
       <VCodemirror v-model="state.value" height="500px" language="yaml" />
     </template>
diff --git a/packages/components/src/components/dialog/Dialog.vue b/packages/components/src/components/dialog/Dialog.vue
index 52c77553..f0f8ad47 100644
--- a/packages/components/src/components/dialog/Dialog.vue
+++ b/packages/components/src/components/dialog/Dialog.vue
@@ -32,6 +32,12 @@ const props = withDefaults(
     confirmType: "primary",
     cancelText: "取消",
     visible: false,
+    onConfirm: () => {
+      return;
+    },
+    onCancel: () => {
+      return;
+    },
   }
 );
 
diff --git a/packages/components/src/components/dialog/DialogProvider.vue b/packages/components/src/components/dialog/DialogProvider.vue
index a506f6b5..fcfac149 100644
--- a/packages/components/src/components/dialog/DialogProvider.vue
+++ b/packages/components/src/components/dialog/DialogProvider.vue
@@ -19,8 +19,8 @@ provide(DialogProviderProvideKey, options);
     :confirm-text="options.confirmText"
     :confirm-type="options.confirmType"
     :description="options.description"
-    :onCancel="options.onCancel"
-    :onConfirm="options.onConfirm"
+    :on-cancel="options.onCancel"
+    :on-confirm="options.onConfirm"
     :title="options.title"
     :type="options.type"
   ></VDialog>
diff --git a/packages/components/src/components/input/Input.vue b/packages/components/src/components/input/Input.vue
index 958bb629..ebf3cd5e 100644
--- a/packages/components/src/components/input/Input.vue
+++ b/packages/components/src/components/input/Input.vue
@@ -10,8 +10,10 @@ const props = withDefaults(
     placeholder?: string;
   }>(),
   {
+    modelValue: undefined,
     size: "md",
     disabled: false,
+    placeholder: undefined,
   }
 );
 
diff --git a/packages/components/src/components/menu/RoutesMenu.tsx b/packages/components/src/components/menu/RoutesMenu.tsx
index 0464686a..14ecd6f4 100644
--- a/packages/components/src/components/menu/RoutesMenu.tsx
+++ b/packages/components/src/components/menu/RoutesMenu.tsx
@@ -10,6 +10,7 @@ const VRoutesMenu = defineComponent({
   props: {
     menus: {
       type: Object as PropType<MenuGroupType[]>,
+      required: true,
     },
   },
   emits: ["select"],
diff --git a/packages/components/src/components/modal/Modal.vue b/packages/components/src/components/modal/Modal.vue
index a083fc7d..fa4d44d5 100644
--- a/packages/components/src/components/modal/Modal.vue
+++ b/packages/components/src/components/modal/Modal.vue
@@ -12,8 +12,10 @@ const props = withDefaults(
   }>(),
   {
     visible: false,
+    title: undefined,
     width: 500,
     fullscreen: false,
+    bodyClass: undefined,
   }
 );
 
diff --git a/packages/components/src/components/pagination/Pagination.vue b/packages/components/src/components/pagination/Pagination.vue
index 0aa41aed..5be32ffe 100644
--- a/packages/components/src/components/pagination/Pagination.vue
+++ b/packages/components/src/components/pagination/Pagination.vue
@@ -51,7 +51,7 @@ watch(
     :key="key"
     v-slot="{ currentPage, next, prev, pageCount }"
     :page="page"
-    :pageSize="size"
+    :page-size="size"
     :total="total"
     @page-change="onPageChange"
     @page-size-change="onPageChange"
diff --git a/packages/components/src/components/radio/RadioGroup.vue b/packages/components/src/components/radio/RadioGroup.vue
index 0afe90f9..fc577279 100644
--- a/packages/components/src/components/radio/RadioGroup.vue
+++ b/packages/components/src/components/radio/RadioGroup.vue
@@ -10,8 +10,11 @@ withDefaults(
     name?: string;
   }>(),
   {
+    modelValue: undefined,
+    options: undefined,
     valueKey: "value",
     labelKey: "label",
+    name: undefined,
   }
 );
 
diff --git a/packages/components/src/components/select/Select.vue b/packages/components/src/components/select/Select.vue
index 772797ce..392bd14e 100644
--- a/packages/components/src/components/select/Select.vue
+++ b/packages/components/src/components/select/Select.vue
@@ -10,8 +10,10 @@ const props = withDefaults(
     placeholder?: string;
   }>(),
   {
+    modelValue: undefined,
     size: "md",
     disabled: false,
+    placeholder: undefined,
   }
 );
 
diff --git a/packages/components/src/components/tabs/Tabbar.vue b/packages/components/src/components/tabs/Tabbar.vue
index 6ca60540..9c8c4fa8 100644
--- a/packages/components/src/components/tabs/Tabbar.vue
+++ b/packages/components/src/components/tabs/Tabbar.vue
@@ -12,6 +12,8 @@ const props = withDefaults(
     labelKey?: string;
   }>(),
   {
+    activeId: undefined,
+    items: undefined,
     type: "default",
     direction: "row",
     idKey: "id",
diff --git a/packages/components/src/components/tabs/Tabs.vue b/packages/components/src/components/tabs/Tabs.vue
index 160a70e7..aff38dd3 100644
--- a/packages/components/src/components/tabs/Tabs.vue
+++ b/packages/components/src/components/tabs/Tabs.vue
@@ -13,6 +13,7 @@ const props = withDefaults(
     labelKey?: string;
   }>(),
   {
+    activeId: undefined,
     type: "default",
     direction: "row",
     idKey: "id",
@@ -54,7 +55,7 @@ const handleChange = (id: string | number) => {
   <div :class="classes" class="tabs-wrapper">
     <div class="tabs-bar-wrapper">
       <VTabbar
-        :activeId="activeId"
+        :active-id="activeId"
         :direction="direction"
         :items="tabItems"
         :type="type"
diff --git a/packages/components/src/components/textarea/Textarea.vue b/packages/components/src/components/textarea/Textarea.vue
index 0877e6ea..7b102f58 100644
--- a/packages/components/src/components/textarea/Textarea.vue
+++ b/packages/components/src/components/textarea/Textarea.vue
@@ -7,7 +7,9 @@ withDefaults(
     rows?: number;
   }>(),
   {
+    modelValue: undefined,
     disabled: false,
+    placeholder: undefined,
     rows: 3,
   }
 );
diff --git a/packages/shared/package.json b/packages/shared/package.json
index ab385170..d718f0e6 100644
--- a/packages/shared/package.json
+++ b/packages/shared/package.json
@@ -8,7 +8,9 @@
   "scripts": {
     "dev": "vite build --watch",
     "build": "vite build",
-    "typecheck": "vue-tsc --noEmit -p tsconfig.app.json --composite false"
+    "typecheck": "vue-tsc --noEmit -p tsconfig.app.json --composite false",
+    "lint": "eslint ./src --ext .vue,.js,.jsx,.cjs,.mjs,.ts,.tsx,.cts,.mts",
+    "prettier": "prettier --write './src/**/*.{vue,js,jsx,ts,tsx,css,scss,json,yml,yaml,html}'"
   },
   "keywords": [],
   "author": {
diff --git a/src/modules/contents/attachments/components/AttachmentUploadModal.vue b/src/modules/contents/attachments/components/AttachmentUploadModal.vue
index 896ff578..296c5dbc 100644
--- a/src/modules/contents/attachments/components/AttachmentUploadModal.vue
+++ b/src/modules/contents/attachments/components/AttachmentUploadModal.vue
@@ -93,7 +93,7 @@ const onVisibleChange = (visible: boolean) => {
         label-idle="Drop files here..."
         name="test"
         server="/api"
-        v-bind:allow-multiple="true"
+        :allow-multiple="true"
       />
     </div>
   </VModal>
diff --git a/src/modules/contents/posts/PostList.vue b/src/modules/contents/posts/PostList.vue
index fc6ebd68..4d5b1fab 100644
--- a/src/modules/contents/posts/PostList.vue
+++ b/src/modules/contents/posts/PostList.vue
@@ -706,8 +706,8 @@ function handlePhaseFilterItemChange(filterItem: FilterItem) {
                       class="inline-flex flex-wrap gap-1 text-xs text-gray-500"
                     >
                       分类：<span
-                        v-for="(category, index) in post.categories"
-                        :key="index"
+                        v-for="(category, categoryIndex) in post.categories"
+                        :key="categoryIndex"
                         class="cursor-pointer hover:text-gray-900"
                       >
                         {{ category.spec.displayName }}
@@ -720,11 +720,11 @@ function handlePhaseFilterItemChange(filterItem: FilterItem) {
               </div>
               <div class="flex">
                 <div
-                  class="inline-flex flex-col flex-col-reverse items-end gap-4 sm:flex-row sm:items-center sm:gap-6"
+                  class="inline-flex flex-col items-end gap-4 sm:flex-row sm:items-center sm:gap-6"
                 >
                   <RouterLink
-                    v-for="(contributor, index) in post.contributors"
-                    :key="index"
+                    v-for="(contributor, contributorIndex) in post.contributors"
+                    :key="contributorIndex"
                     :to="{
                       name: 'UserDetail',
                       params: { name: contributor.name },
diff --git a/src/modules/contents/posts/components/PostPreviewModal.vue b/src/modules/contents/posts/components/PostPreviewModal.vue
index 75d5185b..4cd747f4 100644
--- a/src/modules/contents/posts/components/PostPreviewModal.vue
+++ b/src/modules/contents/posts/components/PostPreviewModal.vue
@@ -27,7 +27,7 @@ const onVisibleChange = (visible: boolean) => {
 </script>
 <template>
   <VModal
-    :bodyClass="['!p-0']"
+    :body-class="['!p-0']"
     :visible="visible"
     fullscreen
     title="文章预览"
diff --git a/src/modules/dashboard/widgets/JournalPublishWidget.vue b/src/modules/dashboard/widgets/JournalPublishWidget.vue
index e49ed8ad..a28bea59 100644
--- a/src/modules/dashboard/widgets/JournalPublishWidget.vue
+++ b/src/modules/dashboard/widgets/JournalPublishWidget.vue
@@ -3,7 +3,7 @@ import { VButton, VCard, VTextarea } from "@halo-dev/components";
 </script>
 <template>
   <VCard
-    :bodyClass="['h-full', 'overflow-y-auto']"
+    :body-class="['h-full', 'overflow-y-auto']"
     class="h-full"
     title="日志发表"
   >
diff --git a/src/modules/dashboard/widgets/QuickLinkWidget.vue b/src/modules/dashboard/widgets/QuickLinkWidget.vue
index fe6e5d6f..01d52f26 100644
--- a/src/modules/dashboard/widgets/QuickLinkWidget.vue
+++ b/src/modules/dashboard/widgets/QuickLinkWidget.vue
@@ -42,7 +42,7 @@ const router = useRouter();
 </script>
 <template>
   <VCard
-    :bodyClass="['h-full', 'overflow-y-auto', '!p-0']"
+    :body-class="['h-full', 'overflow-y-auto', '!p-0']"
     class="h-full"
     title="快捷访问"
   >
diff --git a/src/modules/dashboard/widgets/RecentLoginWidget.vue b/src/modules/dashboard/widgets/RecentLoginWidget.vue
index be4cd11f..7ab840d0 100644
--- a/src/modules/dashboard/widgets/RecentLoginWidget.vue
+++ b/src/modules/dashboard/widgets/RecentLoginWidget.vue
@@ -6,7 +6,7 @@ const { users } = useUserFetch();
 </script>
 <template>
   <VCard
-    :bodyClass="['h-full', '!p-0', 'overflow-y-auto']"
+    :body-class="['h-full', '!p-0', 'overflow-y-auto']"
     class="h-full"
     title="最近登录"
   >
diff --git a/src/modules/dashboard/widgets/RecentPublishedWidget.vue b/src/modules/dashboard/widgets/RecentPublishedWidget.vue
index a9a96953..1b44a163 100644
--- a/src/modules/dashboard/widgets/RecentPublishedWidget.vue
+++ b/src/modules/dashboard/widgets/RecentPublishedWidget.vue
@@ -21,7 +21,7 @@ onMounted(handleFetchPosts);
 </script>
 <template>
   <VCard
-    :bodyClass="['h-full', '!p-0', 'overflow-y-auto']"
+    :body-class="['h-full', '!p-0', 'overflow-y-auto']"
     class="h-full"
     title="最近发布"
   >
diff --git a/src/modules/interface/menus/components/MenuList.vue b/src/modules/interface/menus/components/MenuList.vue
index 587f2f04..092edad4 100644
--- a/src/modules/interface/menus/components/MenuList.vue
+++ b/src/modules/interface/menus/components/MenuList.vue
@@ -119,7 +119,7 @@ defineExpose({
     :menu="selectedMenuToUpdate"
     @close="handleFetchMenus"
   />
-  <VCard :bodyClass="['!p-0']" title="菜单">
+  <VCard :body-class="['!p-0']" title="菜单">
     <VEmpty
       v-if="!menus.length && !loading"
       message="你可以尝试刷新或者新建菜单"
diff --git a/src/modules/system/roles/components/RoleEditingModal.vue b/src/modules/system/roles/components/RoleEditingModal.vue
index 0897cdb5..e817e1e1 100644
--- a/src/modules/system/roles/components/RoleEditingModal.vue
+++ b/src/modules/system/roles/components/RoleEditingModal.vue
@@ -156,13 +156,13 @@ const handleResetForm = () => {
               </dt>
               <dd class="mt-1 text-sm text-gray-900 sm:col-span-2 sm:mt-0">
                 <ul class="space-y-2">
-                  <li v-for="(role, index) in group.roles" :key="index">
+                  <li v-for="(roleTemplate, index) in group.roles" :key="index">
                     <label
                       class="inline-flex w-full cursor-pointer flex-row items-center gap-4 rounded-base border p-5 hover:border-primary"
                     >
                       <input
                         v-model="selectedRoleTemplates"
-                        :value="role.metadata.name"
+                        :value="roleTemplate.metadata.name"
                         class="h-4 w-4 rounded border-gray-300 text-indigo-600"
                         type="checkbox"
                         @change="handleRoleTemplateSelect"
@@ -170,14 +170,14 @@ const handleResetForm = () => {
                       <div class="flex flex-1 flex-col gap-y-3">
                         <span class="font-medium text-gray-900">
                           {{
-                            role.metadata.annotations?.[
+                            roleTemplate.metadata.annotations?.[
                               rbacAnnotations.DISPLAY_NAME
                             ]
                           }}
                         </span>
                         <span
                           v-if="
-                            role.metadata.annotations?.[
+                            roleTemplate.metadata.annotations?.[
                               rbacAnnotations.DEPENDENCIES
                             ]
                           "
@@ -186,7 +186,7 @@ const handleResetForm = () => {
                           依赖于
                           {{
                             JSON.parse(
-                              role.metadata.annotations?.[
+                              roleTemplate.metadata.annotations?.[
                                 rbacAnnotations.DEPENDENCIES
                               ]
                             ).join(", ")
diff --git a/src/modules/system/users/UserList.vue b/src/modules/system/users/UserList.vue
index 19b0eac8..fe4c05ef 100644
--- a/src/modules/system/users/UserList.vue
+++ b/src/modules/system/users/UserList.vue
@@ -311,11 +311,11 @@ onMounted(() => {
               </div>
               <div class="flex">
                 <div
-                  class="inline-flex flex-col flex-col-reverse items-end gap-4 sm:flex-row sm:items-center sm:gap-6"
+                  class="inline-flex flex-col items-end gap-4 sm:flex-row sm:items-center sm:gap-6"
                 >
                   <div
-                    v-for="(role, index) in getRoles(user)"
-                    :key="index"
+                    v-for="(role, roleIndex) in getRoles(user)"
+                    :key="roleIndex"
                     class="hidden items-center sm:flex"
                   >
                     <VTag>