github
/
filebrowser
mirror of https://github.com/filebrowser/filebrowser
1
0
Fork 0
Code Issues Releases Wiki Activity

fix: Fix user creation on proxy auth (#3666) 

* Fix user creation on proxy auth

* Refactoring

---------

Co-authored-by: Oleg Lobanov <oleg@lobanov.me>
pull/3543/head^2
Arran Hobson Sayers 2025-01-30 10:28:19 +00:00 committed by GitHub
parent bbdd313705
commit 5300d00d2e
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 36 additions and 30 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
auth/proxy.go
View File

@ -23,8 +23,15 @@ func (a ProxyAuth) Auth(r *http.Request, usr users.Store, setting *settings.Sett
username := r.Header.Get(a.Header) username := r.Header.Get(a.Header)
user, err := usr.Get(srv.Root, username) user, err := usr.Get(srv.Root, username)
if errors.Is(err, fbErrors.ErrNotExist) { if errors.Is(err, fbErrors.ErrNotExist) {
randomPasswordBytes := make([]byte, 32) //nolint:gomnd return a.createUser(usr, setting, srv, username)
_, err = rand.Read(randomPasswordBytes) }
return user, err
}
func (a ProxyAuth) createUser(usr users.Store, setting *settings.Settings, srv *settings.Server, username string) (*users.User, error) {
const passwordSize = 32
randomPasswordBytes := make([]byte, passwordSize)
_, err := rand.Read(randomPasswordBytes)
if err != nil { if err != nil {
return nil, err return nil, err
} }
@ -35,7 +42,7 @@ func (a ProxyAuth) Auth(r *http.Request, usr users.Store, setting *settings.Sett
return nil, err return nil, err
} }
user = &users.User{ user := &users.User{
Username: username, Username: username,
Password: hashedRandomPassword, Password: hashedRandomPassword,
LockPassword: true, LockPassword: true,
@ -53,9 +60,8 @@ func (a ProxyAuth) Auth(r *http.Request, usr users.Store, setting *settings.Sett
if err != nil { if err != nil {
return nil, err return nil, err
} }
}
return user, err return user, nil
} }
// LoginPage tells that proxy auth doesn't require a login page. // LoginPage tells that proxy auth doesn't require a login page.