mirror of https://github.com/fail2ban/fail2ban
35 lines
1.2 KiB
Diff
35 lines
1.2 KiB
Diff
From bd457781df3442b6721360a9f190428994292e15 Mon Sep 17 00:00:00 2001
|
|
From: Yaroslav Halchenko <debian@onerussian.com>
|
|
Date: Sun, 21 Jan 2018 22:01:24 -0500
|
|
Subject: [PATCH] BF: RF test for "being a root" to check if actually can read
|
|
the file
|
|
|
|
---
|
|
fail2ban/tests/filtertestcase.py | 10 +++++++++-
|
|
1 file changed, 9 insertions(+), 1 deletion(-)
|
|
|
|
diff --git a/fail2ban/tests/filtertestcase.py b/fail2ban/tests/filtertestcase.py
|
|
index b707beb5..40cf51f9 100644
|
|
--- a/fail2ban/tests/filtertestcase.py
|
|
+++ b/fail2ban/tests/filtertestcase.py
|
|
@@ -675,7 +675,15 @@ class LogFileMonitor(LogCaptureTestCase):
|
|
os.chmod(self.name, 0)
|
|
self.filter.getFailures(self.name)
|
|
failure_was_logged = self._is_logged('Unable to open %s' % self.name)
|
|
- is_root = getpass.getuser() == 'root'
|
|
+ # verify that we cannot access the file. Checking by name of user is not
|
|
+ # sufficient since could be a fakeroot or some other super-user
|
|
+ try:
|
|
+ with open(self.name) as f:
|
|
+ f.read()
|
|
+ is_root = True
|
|
+ except IOError:
|
|
+ is_root = False
|
|
+
|
|
# If ran as root, those restrictive permissions would not
|
|
# forbid log to be read.
|
|
self.assertTrue(failure_was_logged != is_root)
|
|
--
|
|
2.15.1
|
|
|