BF: Resolve Deprecation Warnings for python3

Mainly python imp -> importlib for python3.3+, and other minor tweaks
pull/592/head
Steven Hiscocks 2014-01-20 22:46:17 +00:00
parent 79da66df5d
commit e614a2f4a4
5 changed files with 17 additions and 9 deletions

View File

@ -118,7 +118,7 @@ class JailReader(ConfigReader):
return False
else:
self.__filter = None
logSys.warn("No filter set for jail %s" % self.__name)
logSys.warning("No filter set for jail %s" % self.__name)
# Read action
for act in self.__opts["action"].split('\n'):

View File

@ -26,7 +26,11 @@ __license__ = "GPL"
import time, logging
import os
import imp
import sys
if sys.version_info >= (3, 3):
import importlib
else:
import imp
from collections import Mapping
from .banmanager import BanManager
@ -95,8 +99,12 @@ class Actions(JailThread, Mapping):
action = CommandAction(self._jail, name)
else:
pythonModuleName = os.path.basename(pythonModule.strip(".py"))
customActionModule = imp.load_source(
pythonModuleName, pythonModule)
if sys.version_info >= (3, 3):
customActionModule = importlib.machinery.SourceFileLoader(
pythonModuleName, pythonModule).load_module()
else:
customActionModule = imp.load_source(
pythonModuleName, pythonModule)
if not hasattr(customActionModule, "Action"):
raise RuntimeError(
"%s module does not have 'Action' class" % pythonModule)

View File

@ -187,7 +187,7 @@ class DateStrptime(DateTemplate):
date += delta
date = date.replace(tzinfo=iso8601.Utc())
else:
logSys.warn("No _z group captured and %%z is not supported on current platform"
logSys.warning("No _z group captured and %%z is not supported on current platform"
" - timezone ignored and assumed to be localtime. date: %s on line: %s"
% (date, line))

View File

@ -849,7 +849,7 @@ class DNSUtils:
try:
return set(socket.gethostbyname_ex(dns)[2])
except socket.error, e:
logSys.warn("Unable to find a corresponding IP address for %s: %s"
logSys.warning("Unable to find a corresponding IP address for %s: %s"
% (dns, e))
return list()
except socket.error, e:

View File

@ -138,7 +138,7 @@ class DatabaseTest(unittest.TestCase):
ticket = FailTicket("127.0.0.1", 0, ["abc\n"])
self.db.addBan(self.jail, ticket)
self.assertEquals(len(self.db.getBans(jail=self.jail)), 1)
self.assertEqual(len(self.db.getBans(jail=self.jail)), 1)
self.assertTrue(
isinstance(self.db.getBans(jail=self.jail)[0], FailTicket))
@ -146,8 +146,8 @@ class DatabaseTest(unittest.TestCase):
self.testAddJail()
ticket = FailTicket("127.0.0.1", MyTime.time() - 40, ["abc\n"])
self.db.addBan(self.jail, ticket)
self.assertEquals(len(self.db.getBans(jail=self.jail,bantime=50)), 1)
self.assertEquals(len(self.db.getBans(jail=self.jail,bantime=20)), 0)
self.assertEqual(len(self.db.getBans(jail=self.jail,bantime=50)), 1)
self.assertEqual(len(self.db.getBans(jail=self.jail,bantime=20)), 0)
def testGetBansMerged(self):
self.testAddJail()