github
/
fail2ban
mirror of https://github.com/fail2ban/fail2ban
1
0
Fork 0
Code Issues Releases Wiki Activity

code review: getHostname can return ''

pull/1758/head
sebres 2017-04-24 21:32:40 +02:00
parent f75c3d8a02
commit e4ccbe7286
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
fail2ban/server/ipdns.py
View File

@ -147,9 +147,9 @@ class DNSUtils:
names = DNSUtils.CACHE_ipToName.get(key) names = DNSUtils.CACHE_ipToName.get(key)
# get it using different ways (a set with names of localhost, hostname, fully qualified): # get it using different ways (a set with names of localhost, hostname, fully qualified):
if names is None: if names is None:
names = set(['localhost']) names = set([
for fqdn in (False, True): 'localhost', DNSUtils.getHostname(False), DNSUtils.getHostname(True)
names.add(DNSUtils.getHostname(fqdn=fqdn)) ]) - set(['']) # getHostname can return ''
# cache and return : # cache and return :
DNSUtils.CACHE_ipToName.set(key, names) DNSUtils.CACHE_ipToName.set(key, names)
return names return names