github
/
fail2ban
mirror of https://github.com/fail2ban/fail2ban
1
0
Fork 0
Code Issues Releases Wiki Activity

BF: Add error handling in badips.py action

pull/641/head
Steven Hiscocks 2014-02-14 17:10:34 +00:00
parent dff8909473
commit cf81ddd8e2
1 changed files with 51 additions and 38 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

31
config/action.d/badips.py
View File

@ -20,6 +20,7 @@
import json import json
from functools import partial from functools import partial
import threading import threading
import logging
import sys import sys
if sys.version_info >= (3, ): if sys.version_info >= (3, ):
from urllib.request import Request, urlopen from urllib.request import Request, urlopen
@ -207,6 +208,7 @@ class BadIPsAction(ActionBase):
def _banIPs(self, ips): def _banIPs(self, ips):
for ip in ips: for ip in ips:
try:
self._jail.actions[self.banaction].ban({ self._jail.actions[self.banaction].ban({
'ip': ip, 'ip': ip,
'failures': 0, 'failures': 0,
@ -214,6 +216,12 @@ class BadIPsAction(ActionBase):
'ipmatches': "", 'ipmatches': "",
'ipjailmatches': "", 'ipjailmatches': "",
}) })
except Exception as e:
self._logSys.error(
"Error banning IP %s for jail '%s' with action '%s': %s",
ip, self._jail.getName(), self.banaction, e,
exc_info=self._logSys.getEffectiveLevel<=logging.DEBUG)
else:
self._bannedips.add(ip) self._bannedips.add(ip)
self._logSys.info( self._logSys.info(
"Banned IP %s for jail '%s' with action '%s'", "Banned IP %s for jail '%s' with action '%s'",
@ -221,6 +229,7 @@ class BadIPsAction(ActionBase):
def _unbanIPs(self, ips): def _unbanIPs(self, ips):
for ip in ips: for ip in ips:
try:
self._jail.actions[self.banaction].unban({ self._jail.actions[self.banaction].unban({
'ip': ip, 'ip': ip,
'failures': 0, 'failures': 0,
@ -228,21 +237,23 @@ class BadIPsAction(ActionBase):
'ipmatches': "", 'ipmatches': "",
'ipjailmatches': "", 'ipjailmatches': "",
}) })
self._bannedips.remove(ip) except Exception as e:
self._logSys.info(
"Error unbanning IP %s for jail '%s' with action '%s': %s",
ip, self._jail.getName(), self.banaction, e,
exc_info=self._logSys.getEffectiveLevel<=logging.DEBUG)
else:
self._logSys.info( self._logSys.info(
"Unbanned IP %s for jail '%s' with action '%s'", "Unbanned IP %s for jail '%s' with action '%s'",
ip, self._jail.getName(), self.banaction) ip, self._jail.getName(), self.banaction)
finally:
self._bannedips.remove(ip)
def start(self): def start(self):
"""If `banaction` set, blacklists bad IPs. """If `banaction` set, blacklists bad IPs.
""" """
if self.banaction is not None: if self.banaction is not None:
self._banIPs(self.getList(self.category, self.score, self.age)) self.update()
self._timer = threading.Timer(self.updateperiod, self.update)
self._timer.start()
self._logSys.info(
"Banned IPs for jail '%s'. Update in %i seconds",
self._jail.getName(), self.updateperiod)
def update(self): def update(self):
"""If `banaction` set, updates blacklisted IPs. """If `banaction` set, updates blacklisted IPs.
@ -256,17 +267,19 @@ class BadIPsAction(ActionBase):
self._timer.cancel() self._timer.cancel()
self._timer = None self._timer = None
try:
ips = self.getList(self.category, self.score, self.age) ips = self.getList(self.category, self.score, self.age)
# Remove old IPs no longer listed # Remove old IPs no longer listed
self._unbanIPs(self._bannedips - ips) self._unbanIPs(self._bannedips - ips)
# Add new IPs which are now listed # Add new IPs which are now listed
self._banIPs(ips - self._bannedips) self._banIPs(ips - self._bannedips)
self._timer = threading.Timer(self.updateperiod, self.update)
self._timer.start()
self._logSys.info( self._logSys.info(
"Updated IPs for jail '%s'. Update again in %i seconds", "Updated IPs for jail '%s'. Update again in %i seconds",
self._jail.getName(), self.updateperiod) self._jail.getName(), self.updateperiod)
finally:
self._timer = threading.Timer(self.updateperiod, self.update)
self._timer.start()
def stop(self): def stop(self):
"""If `banaction` set, clears blacklisted IPs. """If `banaction` set, clears blacklisted IPs.