github
/
fail2ban
mirror of https://github.com/fail2ban/fail2ban
1
0
Fork 0
Code Issues Releases Wiki Activity

BF: general Exception catch was excessive. Only IOError and OSError are possible and has different meanings

pull/134/head
Daniel Black 2013-03-10 15:29:27 +11:00
parent 6e77427516
commit c8c7b0b984
1 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
server/filter.py
View File

@ -477,10 +477,15 @@ class FileFilter(Filter):
# Try to open log file. # Try to open log file.
try: try:
container.open() container.open()
except Exception, e: # see http://python.org/dev/peps/pep-3151/
except IOError, e:
logSys.error("Unable to open %s" % filename) logSys.error("Unable to open %s" % filename)
logSys.exception(e) logSys.exception(e)
return False return False
except OSError, e: # pragma: no cover - requires race condition to tigger this
logSys.error("Error opening %s" % filename)
logSys.exception(e)
return False
while True: while True:
line = container.readline() line = container.readline()