TST: Mandate that all filters and each regex has sample log entry

pull/303/merge^2
Steven Hiscocks 2013-07-26 17:05:17 +01:00
parent 1c7d28d1ea
commit bf021ebd97
1 changed files with 7 additions and 16 deletions

View File

@ -72,14 +72,9 @@ def testSampleRegexsFactory(name):
# No fail regexs set: likely just common file for includes. # No fail regexs set: likely just common file for includes.
return return
# TODO: Remove exception handling once sample logs obtained for all
try:
self.assertTrue( self.assertTrue(
os.path.isfile(os.path.join(TEST_FILES_DIR, "logs", name)), os.path.isfile(os.path.join(TEST_FILES_DIR, "logs", name)),
"No sample log file available for '%s' filter" % name) "No sample log file available for '%s' filter" % name)
except AssertionError:
print "I: No sample log file available for '%s' filter" % name
return
logFile = fileinput.FileInput( logFile = fileinput.FileInput(
os.path.join(TEST_FILES_DIR, "logs", name)) os.path.join(TEST_FILES_DIR, "logs", name))
@ -124,14 +119,10 @@ def testSampleRegexsFactory(name):
# TODO: Remove exception handling once all regexs have samples # TODO: Remove exception handling once all regexs have samples
for failRegexIndex, failRegex in enumerate(self.filter.getFailRegex()): for failRegexIndex, failRegex in enumerate(self.filter.getFailRegex()):
try:
self.assertTrue( self.assertTrue(
failRegexIndex in regexsUsed, failRegexIndex in regexsUsed,
"Regex for filter '%s' has no samples: %i: %r" % "Regex for filter '%s' has no samples: %i: %r" %
(name, failRegexIndex, failRegex)) (name, failRegexIndex, failRegex))
except AssertionError:
print "I: Regex for filter '%s' has no samples: %i: %r" % (
name, failRegexIndex, failRegex)
return testFilter return testFilter