RF/BF: just use pyinotify.ThreadedNotifier thread in filterpyinotify

that seems also to overcome the problem of often locking upon stop()

server/filterpyinotify.py

@@ -101,42 +101,36 @@ class FilterPyinotify(FileFilter):
 	##
 	# Main loop.
 	#
-	# This function is the main loop of the thread. It checks if the
+	# Since all detection is offloaded to pyinotifier -- no manual
-	# file has been modified and looks for failures.
+	# loop is necessary
-	# @return True when the thread exits nicely
 
 	def run(self):
 		self.setActive(True)
 		self.__notifier = pyinotify.ThreadedNotifier(self.__monitor,
 			ProcessPyinotify(self))
 		self.__notifier.start()
-		while self._isActive():
+		logSys.debug("pyinotifier started for %s." % self.jail.getName())
-			if not self.getIdle():
+		# TODO: verify that there is nothing really to be done for
-				self.__notifier.process_events()
+		#       idle jails
-				if self.__notifier.check_events():
-					self.__notifier.read_events()
-			else:
-				time.sleep(self.getSleepTime())
-		# Cleanup pyinotify
-		self.__cleanup()
-		logSys.debug(self.jail.getName() + ": filter terminated")
 		return True
 
 	##
 	# Call super.stop() and then stop the 'Notifier'
 
 	def stop(self):
-		# Call super to set __isRunning
 		super(FilterPyinotify, self).stop()
-		# Now stop the Notifier, otherwise we're deadlocked
+
+		# Stop the notifier thread
 		self.__notifier.stop()
+		self.__notifier.join()			# to not exit before notifier does
+		self.__cleanup()				# for pedantic ones
 
 	##
 	# Deallocates the resources used by pyinotify.
 
 	def __cleanup(self):
-		del self.__notifier
+		self.__notifier = None
-		del self.__monitor
+		self.__monitor = None
 
 
 class ProcessPyinotify(pyinotify.ProcessEvent):