github
/
fail2ban
mirror of https://github.com/fail2ban/fail2ban
1
0
Fork 0
Code Issues Releases Wiki Activity

- Re-activated subprocess module 

- A return code different than 0 is considered as an error

git-svn-id: https://fail2ban.svn.sourceforge.net/svnroot/fail2ban/trunk@428 a942ae1a-1317-0410-a47c-b1dcaea8d605
0.x
Cyril Jaquier 2006-10-23 20:12:15 +00:00
parent f74657f4b6
commit a522d9b6d7
1 changed files with 7 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
server/action.py
View File

@ -25,7 +25,7 @@ __copyright__ = "Copyright (c) 2004 Cyril Jaquier"
__license__ = "GPL" __license__ = "GPL"
import logging, os import logging, os
#from subprocess import call from subprocess import call
# Gets the instance of the logger. # Gets the instance of the logger.
logSys = logging.getLogger("fail2ban.actions.action") logSys = logging.getLogger("fail2ban.actions.action")
@ -214,13 +214,13 @@ class Action:
logSys.debug(realCmd) logSys.debug(realCmd)
try: try:
# The following line gives deadlock with multiple jails # The following line gives deadlock with multiple jails
#retcode = call(realCmd, shell=True) retcode = call(realCmd, shell=True)
retcode = os.system(realCmd) #retcode = os.system(realCmd)
if retcode < 0: if retcode == 0:
logSys.error("%s returned %x" % (realCmd, -retcode)) logSys.debug("%s returned successfully" % realCmd)
else:
logSys.debug("%s returned %x" % (realCmd, retcode))
return True return True
else:
logSys.error("%s returned %x" % (realCmd, retcode))
except OSError, e: except OSError, e:
logSys.error("%s failed with %s" % (realCmd, e)) logSys.error("%s failed with %s" % (realCmd, e))
return False return False