github
/
fail2ban
mirror of https://github.com/fail2ban/fail2ban
1
0
Fork 0
Code Issues Releases Wiki Activity

test_smtp inconsistency for py3+IPv6 

It appears that, under Python3, on an IPv6 enabled machine,
the testing SMTP server on 'localhost' can turn out to listen on ::1 only,
which makes those tests break if the SMTP client part uses 127.0.0.1
directly. Using 'localhost' there as well makes the tests pass.
pull/1739/head
Georges Racinet 2017-03-28 19:29:45 +02:00
parent 873f97c6c5
commit 7b93f111e1
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
fail2ban/tests/action_d/test_smtp.py
View File

@ -67,7 +67,7 @@ class SMTPActionTest(unittest.TestCase):
port = self.smtpd.socket.getsockname()[1] port = self.smtpd.socket.getsockname()[1]
self.action = customActionModule.Action( self.action = customActionModule.Action(
self.jail, "test", host="127.0.0.1:%i" % port) self.jail, "test", host="localhost:%i" % port)
## because of bug in loop (see loop in asyncserver.py) use it's loop instead of asyncore.loop: ## because of bug in loop (see loop in asyncserver.py) use it's loop instead of asyncore.loop:
self._active = True self._active = True