From 505d51fd5df151a093c6423d1762785cff435fb2 Mon Sep 17 00:00:00 2001 From: "Sergey G. Brester" Date: Tue, 4 Mar 2025 19:19:57 +0100 Subject: [PATCH] Update PULL_REQUEST_TEMPLATE.md --- .github/PULL_REQUEST_TEMPLATE.md | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 350d6ee2..b53003d5 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -1,12 +1,10 @@ Before submitting your PR, please review the following checklist: -- [ ] **CHOOSE CORRECT BRANCH**: if filing a bugfix/enhancement - against certain release version, choose `0.9`, `0.10` or `0.11` branch, - for dev-edition use `master` branch - [ ] **CONSIDER adding a unit test** if your PR resolves an issue -- [ ] **LIST ISSUES** this PR resolves +- [ ] **LIST ISSUES** this PR resolves or describe the approach in detail - [ ] **MAKE SURE** this PR doesn't break existing tests -- [ ] **KEEP PR small** so it could be easily reviewed. +- [ ] **KEEP PR small** so it could be easily reviewed - [ ] **AVOID** making unnecessary stylistic changes in unrelated code - [ ] **ACCOMPANY** each new `failregex` for filter `X` with sample log lines - within `fail2ban/tests/files/logs/X` file + (and `# failJSON`) within `fail2ban/tests/files/logs/X` file +- [ ] **PROVIDE ChangeLog** entry describing the pull request