diff --git a/testcases/filtertestcase.py b/testcases/filtertestcase.py index 4e03b3427..e83840cba 100644 --- a/testcases/filtertestcase.py +++ b/testcases/filtertestcase.py @@ -222,12 +222,24 @@ class GetFailures(unittest.TestCase): class DNSUtilsTests(unittest.TestCase): - def testTextToIp(self, useDns): - # Bogus addresses which should have no DNS matches - bogus = [ + def testUseDns(self): + res = DNSUtils.textToIp('www.example.com', 'no') + self.assertEqual(res, None) + res = DNSUtils.textToIp('www.example.com', 'warn') + self.assertEqual(res, ['192.0.43.10']) + res = DNSUtils.textToIp('www.example.com', 'yes') + self.assertEqual(res, ['192.0.43.10']) + + def testTextToIp(self): + # Test hostnames + hostnames = [ + 'www.example.com' 'doh1.2.3.4.buga.xxxxx.yyy.invalid', '1.2.3.4.buga.xxxxx.yyy.invalid', ] - for s in bogus: - res = DNSUtils.textToIp(s, useDns) - self.assertEqual(res, []) + for s in hostnames: + res = DNSUtils.textToIp(s, 'yes') + if s is 'www.example.com': + self.assertEqual(res, ['192.0.43.10']) + else: + self.assertEqual(res, [])