github
/
fail2ban
mirror of https://github.com/fail2ban/fail2ban
1
0
Fork 0
Code Issues Releases Wiki Activity

coverage and code review

pull/2402/head
sebres 2019-04-18 21:48:58 +02:00
parent 852cb0362c
commit 4629e4320f
2 changed files with 10 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
fail2ban/server/transmitter.py
View File

@ -186,7 +186,7 @@ class Transmitter:
elif name == "dbmaxmatches": elif name == "dbmaxmatches":
db = self.__server.getDatabase() db = self.__server.getDatabase()
if db is None: if db is None:
logSys.msg("dbmaxmatches setting was not in effect since no db yet") logSys.log(logging.MSG, "dbmaxmatches setting was not in effect since no db yet")
return None return None
else: else:
db.maxMatches = int(command[1]) db.maxMatches = int(command[1])
@ -195,7 +195,7 @@ class Transmitter:
elif name == "dbpurgeage": elif name == "dbpurgeage":
db = self.__server.getDatabase() db = self.__server.getDatabase()
if db is None: if db is None:
logSys.warning("dbpurgeage setting was not in effect since no db yet") logSys.log(logging.MSG, "dbpurgeage setting was not in effect since no db yet")
return None return None
else: else:
db.purgeage = command[1] db.purgeage = command[1]

8
fail2ban/tests/servertestcase.py
View File

@ -197,6 +197,8 @@ class Transmitter(TransmitterBase):
self.setGetTest("dbfile", tmpFilename) self.setGetTest("dbfile", tmpFilename)
# the same file name (again no jails / not changed): # the same file name (again no jails / not changed):
self.setGetTest("dbfile", tmpFilename) self.setGetTest("dbfile", tmpFilename)
self.setGetTest("dbmaxmatches", "100", 100)
self.setGetTestNOK("dbmaxmatches", "LIZARD")
self.setGetTest("dbpurgeage", "600", 600) self.setGetTest("dbpurgeage", "600", 600)
self.setGetTestNOK("dbpurgeage", "LIZARD") self.setGetTestNOK("dbpurgeage", "LIZARD")
# the same file name (again with jails / not changed): # the same file name (again with jails / not changed):
@ -211,6 +213,12 @@ class Transmitter(TransmitterBase):
self.assertEqual(self.transm.proceed( self.assertEqual(self.transm.proceed(
["get", "dbfile"]), ["get", "dbfile"]),
(0, None)) (0, None))
self.assertEqual(self.transm.proceed(
["set", "dbmaxmatches", "100"]),
(0, None))
self.assertEqual(self.transm.proceed(
["get", "dbmaxmatches"]),
(0, None))
self.assertEqual(self.transm.proceed( self.assertEqual(self.transm.proceed(
["set", "dbpurgeage", "500"]), ["set", "dbpurgeage", "500"]),
(0, None)) (0, None))