From 31b34950f7944206f7a2ca2303b66550854ee1a4 Mon Sep 17 00:00:00 2001 From: Lee Clemens Date: Fri, 26 Jun 2015 12:14:11 -0400 Subject: [PATCH] Fix pep8 E712 comparison to False should be 'if cond is False:' or 'if not cond:' --- fail2ban/server/actions.py | 2 +- fail2ban/tests/failmanagertestcase.py | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/fail2ban/server/actions.py b/fail2ban/server/actions.py index 951612905..b925ecee4 100644 --- a/fail2ban/server/actions.py +++ b/fail2ban/server/actions.py @@ -295,7 +295,7 @@ class Actions(JailThread, Mapping): True if an IP address get banned. """ ticket = self._jail.getFailTicket() - if ticket != False: + if ticket: aInfo = CallingMap() bTicket = BanManager.createBanTicket(ticket) ip = bTicket.getIP() diff --git a/fail2ban/tests/failmanagertestcase.py b/fail2ban/tests/failmanagertestcase.py index 1f99d1617..659a323d8 100644 --- a/fail2ban/tests/failmanagertestcase.py +++ b/fail2ban/tests/failmanagertestcase.py @@ -100,7 +100,7 @@ class AddFailure(unittest.TestCase): self.assertEqual( ticket_repr, 'FailTicket: ip=193.168.0.128 time=1167605999.0 #attempts=5 matches=[]') - self.assertFalse(ticket == False) + self.assertFalse(not ticket) # and some get/set-ers otherwise not tested ticket.setTime(1000002000.0) self.assertEqual(ticket.getTime(), 1000002000.0)