From 26715d5e5e4b1671ce6cbfabe13a6495a9f64b75 Mon Sep 17 00:00:00 2001 From: Yaroslav Halchenko Date: Thu, 9 May 2013 23:08:20 -0400 Subject: [PATCH] ENH: basic test for setup.py itself (when applicable, should greatly improve coverage ;) ) --- fail2ban-testcases | 1 + testcases/misctestcase.py | 38 +++++++++++++++++++++++++++++++++++++- 2 files changed, 38 insertions(+), 1 deletion(-) diff --git a/fail2ban-testcases b/fail2ban-testcases index 4e6689ea..94b8208e 100755 --- a/fail2ban-testcases +++ b/fail2ban-testcases @@ -153,6 +153,7 @@ tests.addTest(unittest.makeSuite(clientreadertestcase.JailsReaderTest)) tests.addTest(unittest.makeSuite(sockettestcase.Socket)) # Misc helpers tests.addTest(unittest.makeSuite(misctestcase.HelpersTest)) +tests.addTest(unittest.makeSuite(misctestcase.SetupTest)) # Filter if not opts.no_network: diff --git a/testcases/misctestcase.py b/testcases/misctestcase.py index 9b053c13..e3c20882 100644 --- a/testcases/misctestcase.py +++ b/testcases/misctestcase.py @@ -21,7 +21,12 @@ __author__ = "Yaroslav Halchenko" __copyright__ = "Copyright (c) 2013 Yaroslav Halchenko" __license__ = "GPL" -import unittest +import os, sys, unittest +import tempfile +import shutil + +from glob import glob + from common.helpers import formatExceptionInfo class HelpersTest(unittest.TestCase): @@ -42,3 +47,34 @@ class HelpersTest(unittest.TestCase): self.assertEqual(name, "ValueError") # might be fragile due to ' vs " self.assertEqual(args, "('Very bad', None)") + + +class SetupTest(unittest.TestCase): + + def setUp(self): + setup = os.path.join(os.path.dirname(__file__), '..', 'setup.py') + self.setup = os.path.exists(setup) and setup or None + if not self.setup and sys.version_info >= (2,7): # running not out of the source + raise unittest.SkipTest( + "Seems to be running not out of source distribution" + " -- cannot locate setup.py") + + def testSetupInstallRoot(self): + if not self.setup: return # if verbose skip didn't work out + tmp = tempfile.mkdtemp() + os.system("%s install --root=%s >/dev/null" % (self.setup, tmp)) + + def addpath(l): + return [os.path.join(tmp, x) for x in l] + + self.assertEqual(sorted(glob('%s/*' % tmp)), + addpath(['etc', 'usr', 'var'])) + + # Assure presence of some files we expect to see in the installation + for f in ('etc/fail2ban/fail2ban.conf', + 'etc/fail2ban/jail.conf'): + self.assertTrue(os.path.exists(os.path.join(tmp, f)), + msg="Can't find %s" % f) + + # clean up + shutil.rmtree(tmp)