From ca59b2101112d24bda4395cf5b10da43722c1656 Mon Sep 17 00:00:00 2001
From: Leopoldthecoder <Leopoldthecuber@gmail.com>
Date: Mon, 8 Aug 2016 13:59:26 +0800
Subject: [PATCH 1/2] update dialog

---
 examples/docs/dialog.md               | 82 +++++++++++++++------------
 package.json                          |  2 +-
 packages/dialog/package.json          |  2 +-
 packages/dialog/src/component.vue     | 35 +++++++-----
 packages/theme-default/src/dialog.css |  9 +--
 5 files changed, 73 insertions(+), 57 deletions(-)

diff --git a/examples/docs/dialog.md b/examples/docs/dialog.md
index 4fd9b7138..c6da7875b 100644
--- a/examples/docs/dialog.md
+++ b/examples/docs/dialog.md
@@ -60,96 +60,106 @@
 
 ## 基本用法
 
-<el-button :plain="true" v-on:click="dialogVisible = true">点击打开 Dialog</el-button>
+<el-button :plain="true" v-on:click.native="dialogVisible = true">点击打开 Dialog</el-button>
 
 <div class="demo-box demo-dialog">
-  <el-dialog title="提示" :visible.sync="dialogVisible">
+  <el-dialog title="提示" :visible="dialogVisible" @open="dialogVisible = true" @close="dialogVisible = false">
     <span>这是一段信息，这是一段信息，这是一段信息，这是一段信息，这是一段信息，这是一段信息，这是一段信息，这是一段信息</span>
     <span slot="footer" class="dialog-footer">
-      <el-button @click="dialogVisible = false">取 消</el-button>
-      <el-button type="primary" @click="dialogVisible = false">确 定</el-button>
+      <el-button @click.native="dialogVisible = false">取 消</el-button>
+      <el-button type="primary" @click.native="dialogVisible = false">确 定</el-button>
     </span>
   </el-dialog>
 </div>
 
 ```html
-<el-button :plain="true" v-on:click="openDialog">点击打开 Dialog</el-button>
+<el-button :plain="true" v-on:click.native="dialogVisible = true">点击打开 Dialog</el-button>
 
-<el-dialog title="提示" :visible.sync="dialogVisible">
+<el-dialog title="提示" :visible="dialogVisible" @open="dialogVisible = true" @close="dialogVisible = false">
   <span>这是一段信息，这是一段信息，这是一段信息，这是一段信息，这是一段信息，这是一段信息，这是一段信息，这是一段信息</span>
   <span slot="footer" class="dialog-footer">
-    <el-button @click="dialogVisible = false">取 消</el-button>
-    <el-button type="primary" @click="dialogVisible = false">确 定</el-button>
+    <el-button @click.native="dialogVisible = false">取 消</el-button>
+    <el-button type="primary" @click.native="dialogVisible = false">确 定</el-button>
   </span>
 </el-dialog>
 ```
 
 ## 设置尺寸
 
-<el-button :plain="true" v-on:click="dialogTinyVisible = true">点击打开小尺寸 Dialog</el-button>
+<el-button :plain="true" v-on:click.native="dialogTinyVisible = true">点击打开小尺寸 Dialog</el-button>
 
 <div class="demo-box demo-dialog">
-  <el-dialog title="提示" :visible.sync="dialogTinyVisible" size="tiny">
+  <el-dialog title="提示" :visible="dialogTinyVisible" size="tiny" @open="dialogTinyVisible = true" @close="dialogTinyVisible = false">
     <span>这是一段内容</span>
     <span slot="footer" class="dialog-footer">
-      <el-button @click="dialogTinyVisible = false">取 消</el-button>
-      <el-button type="primary" @click="dialogTinyVisible = false">确 定</el-button>
+      <el-button @click.native="dialogTinyVisible = false">取 消</el-button>
+      <el-button type="primary" @click.native="dialogTinyVisible = false">确 定</el-button>
     </span>
   </el-dialog>
 </div>
 
 ```html
-<el-button :plain="true" v-on:click="dialogTinyVisible = true">点击打开小尺寸 Dialog</el-button>
+<el-button :plain="true" v-on:click.native="dialogTinyVisible = true">点击打开小尺寸 Dialog</el-button>
 
-<el-dialog title="提示" :visible.sync="dialogTinyVisible" size="tiny">
+<el-dialog title="提示" :visible="dialogTinyVisible" size="tiny" @open="dialogTinyVisible = true" @close="dialogTinyVisible = false">
   <span>这是一段内容</span>
   <span slot="footer" class="dialog-footer">
-    <el-button @click="dialogTinyVisible = false">取 消</el-button>
-    <el-button type="primary" @click="dialogTinyVisible = false">确 定</el-button>
+    <el-button @click.native="dialogTinyVisible = false">取 消</el-button>
+    <el-button type="primary" @click.native="dialogTinyVisible = false">确 定</el-button>
   </span>
 </el-dialog>
 ```
 
-<el-button v-on:click="dialogFullVisible = true">点击打开全屏幕 Dialog</el-button>
+<el-button v-on:click.native="dialogFullVisible = true">点击打开全屏幕 Dialog</el-button>
 
 <div class="demo-box demo-dialog">
-  <el-dialog title="提示" :visible.sync="dialogFullVisible" size="full">
+  <el-dialog title="提示" :visible="dialogFullVisible" size="full" @open="dialogFullVisible = true" @close="dialogFullVisible = false">
     <img src="http://placekitten.com/1920/1280" class="full-image">
   </el-dialog>
 </div>
 
 ```html
-<el-button v-on:click="dialogFullVisible = true">点击打开全屏幕 Dialog</el-button>
+<el-button v-on:click.native="dialogFullVisible = true">点击打开全屏幕 Dialog</el-button>
 
-<el-dialog title="提示" :visible.sync="dialogFullVisible" size="full">
+<el-dialog title="提示" :visible="dialogFullVisible" size="full" @open="dialogFullVisible = true" @close="dialogFullVisible = false">
   <img src="http://placekitten.com/1920/1280">
 </el-dialog>
 ```
 
 ## 设置能否通过点击modal或按下esc关闭dialog
 
-<el-button v-on:click="dialogStubbornVisible = true">打开 Dialog，点击 modal 或按下 esc 关闭无法将其关闭</el-button>
+<el-button v-on:click.native="dialogStubbornVisible = true">打开 Dialog，点击 modal 或按下 esc 关闭无法将其关闭</el-button>
 
 <div class="demo-box demo-dialog">
-  <el-dialog title="提示" :visible.sync="dialogStubbornVisible" :close-on-click-modal="false" :close-on-press-escape="false">
+  <el-dialog title="提示"
+    :visible="dialogStubbornVisible"
+    @open="dialogStubbornVisible = true"
+    @close="dialogStubbornVisible = false"
+    :close-on-click-modal="false"
+    :close-on-press-escape="false">
     <span>这是一段信息，这是一段信息，这是一段信息，这是一段信息，这是一段信息，这是一段信息，这是一段信息，这是一段信息</span>
   </el-dialog>
 </div>
 
 ```html
-<el-button v-on:click="dialogStubbornVisible = true">打开 Dialog，点击 modal 或按下 esc 关闭无法将其关闭</el-button>
+<el-button v-on:click.native="dialogStubbornVisible = true">打开 Dialog，点击 modal 或按下 esc 关闭无法将其关闭</el-button>
 
-<el-dialog title="提示" :visible.sync="dialogStubbornVisible" :close-on-click-modal="false" :close-on-press-escape="false">
+<el-dialog title="提示"
+  :visible="dialogStubbornVisible"
+  @open="dialogStubbornVisible = true"
+  @close="dialogStubbornVisible = false"
+  :close-on-click-modal="false"
+  :close-on-press-escape="false">
   <span>这是一段信息，这是一段信息，这是一段信息，这是一段信息，这是一段信息，这是一段信息，这是一段信息，这是一段信息</span>
 </el-dialog>
 ```
 
 ## 自定义内容
 
-<el-button v-on:click="dialogTableVisible = true">打开嵌套表格的 Dialog</el-button>
+<el-button v-on:click.native="dialogTableVisible = true">打开嵌套表格的 Dialog</el-button>
 
 <div class="demo-box demo-dialog">
-  <el-dialog title="收货地址" :visible.sync="dialogTableVisible">
+  <el-dialog title="收货地址" :visible="dialogTableVisible" @open="dialogTableVisible = true" @close="dialogTableVisible = false">
     <el-table :data="gridData">
       <el-table-column property="date" label="日期" width="150"></el-table-column>
       <el-table-column property="name" label="姓名" width="200"></el-table-column>
@@ -158,10 +168,10 @@
   </el-dialog>
 </div>
 
-<el-button v-on:click="dialogFormVisible = true">打开嵌套表单的 Dialog</el-button>
+<el-button v-on:click.native="dialogFormVisible = true">打开嵌套表单的 Dialog</el-button>
 
 <div class="demo-box demo-dialog">
-  <el-dialog title="收货地址" :visible.sync="dialogFormVisible">
+  <el-dialog title="收货地址" :visible="dialogFormVisible" @open="dialogFormVisible = true" @close="dialogFormVisible = false">
     <el-form :models="form" v-ref:form>
       <el-form-item label="活动名称" :label-width="formLabelWidth">
         <el-input :model.sync="form.name" auto-complete="off"></el-input>
@@ -174,16 +184,16 @@
       </el-form-item>
     </el-form>
     <span slot="footer" class="dialog-footer">
-      <el-button @click="dialogFormVisible = false">取 消</el-button>
-      <el-button type="primary" @click="dialogFormVisible = false">确 定</el-button>
+      <el-button @click.native="dialogFormVisible = false">取 消</el-button>
+      <el-button type="primary" @click.native="dialogFormVisible = false">确 定</el-button>
     </span>
   </el-dialog>
 </div>
 
 ```html
-<el-button v-on:click="dialogTableVisible = true">打开嵌套表格的 Dialog</el-button>
+<el-button v-on:click.native="dialogTableVisible = true">打开嵌套表格的 Dialog</el-button>
 
-<el-dialog title="收货地址" :visible.sync="dialogTableVisible">
+<el-dialog title="收货地址" :visible="dialogTableVisible" @open="dialogTableVisible = true" @close="dialogTableVisible = false">
   <el-table :data="gridData">
     <el-table-column property="date" label="日期" width="150"></el-table-column>
     <el-table-column property="name" label="姓名" width="200"></el-table-column>
@@ -191,9 +201,9 @@
   </el-table>
 </el-dialog>
 
-<el-button v-on:click="dialogFormVisible = true">打开嵌套表单的 Dialog</el-button>
+<el-button v-on:click.native="dialogFormVisible = true">打开嵌套表单的 Dialog</el-button>
 
-<el-dialog title="收货地址" :visible.sync="dialogFormVisible">
+<el-dialog title="收货地址" :visible="dialogFormVisible" @open="dialogFormVisible = true" @close="dialogFormVisible = false">
   <el-form :models="form" v-ref:form>
     <el-form-item label="活动名称" :label-width="formLabelWidth">
       <el-input :model.sync="form.name" auto-complete="off"></el-input>
@@ -206,8 +216,8 @@
     </el-form-item>
   </el-form>
   <span slot="footer" class="dialog-footer">
-    <el-button @click="dialogFormVisible = false">取 消</el-button>
-    <el-button type="primary" @click="dialogFormVisible = false">确 定</el-button>
+    <el-button @click.native="dialogFormVisible = false">取 消</el-button>
+    <el-button type="primary" @click.native="dialogFormVisible = false">确 定</el-button>
   </span>
 </el-dialog>
 ```
diff --git a/package.json b/package.json
index 6fbf1a7d6..5ea46b612 100644
--- a/package.json
+++ b/package.json
@@ -47,7 +47,7 @@
     "vue": "^2.0.0-beta.5",
     "vue-loader": "^9.2.3",
     "vue-markdown-loader": "^0.4.0",
-    "vue-popup": "^0.1.8",
+    "vue-popup": "^0.2.0",
     "vue-router": "^2.0.0-beta.2"
   }
 }
diff --git a/packages/dialog/package.json b/packages/dialog/package.json
index 32e0c41d9..97aa9482b 100644
--- a/packages/dialog/package.json
+++ b/packages/dialog/package.json
@@ -12,6 +12,6 @@
   "author": "elemefe",
   "license": "MIT",
   "devDependencies": {
-    "vue-popup": "^0.1.8"
+    "vue-popup": "^0.2.0"
   }
 }
diff --git a/packages/dialog/src/component.vue b/packages/dialog/src/component.vue
index 0aa3f3db8..28dc92f41 100644
--- a/packages/dialog/src/component.vue
+++ b/packages/dialog/src/component.vue
@@ -1,16 +1,20 @@
 <template>
-  <div class="el-dialog__wrapper" v-if="visible" transition="dialog-fade" @click.self="handleWrapperClick">
-    <div class="el-dialog" :class="[sizeClass, customClass]" v-el:dialog :style="{ 'margin-bottom': size !== 'full' ? '50px' : '', 'top': size !== 'full' ? dynamicTop + 'px' : '0' }">
-      <div class="el-dialog__header">
-        <span class="el-dialog__title">{{title}}</span>
-        <div class="el-dialog__headerbtn">
-          <i class="el-dialog__close el-icon el-icon-close" @click='close()'></i>
+  <transition name="dialog-fade">
+    <div class="el-dialog__wrapper" v-show="visible" @click.self="handleWrapperClick">
+      <div class="el-dialog" :class="[sizeClass, customClass]" ref="dialog" :style="{ 'margin-bottom': size !== 'full' ? '50px' : '', 'top': size !== 'full' ? dynamicTop + 'px' : '0' }">
+        <div class="el-dialog__header">
+          <span class="el-dialog__title">{{title}}</span>
+          <div class="el-dialog__headerbtn">
+            <i class="el-dialog__close el-icon el-icon-close" @click='close()'></i>
+          </div>
+        </div>
+        <div class="el-dialog__body"><slot></slot></div>
+        <div class="el-dialog__footer">
+          <slot name="footer"></slot>
         </div>
       </div>
-      <div class="el-dialog__body"><slot></slot></div>
-      <slot name="footer"></slot>
     </div>
-  </div>
+  </transition>
 </template>
 
 <script>
@@ -60,9 +64,14 @@
     },
 
     watch: {
-      visible(val) {
+      computedVisible(val) {
         if (val) {
-          this.$els.dialog.scrollTop = 0;
+          this.$emit('open');
+          this.$nextTick(() => {
+            this.$refs.dialog.scrollTop = 0;
+          });
+        } else {
+          this.$emit('close');
         }
       }
     },
@@ -76,7 +85,7 @@
     methods: {
       handleWrapperClick() {
         if (this.closeOnClickModal) {
-          this.visible = false;
+          this.computedVisible = false;
         }
       },
 
@@ -85,7 +94,7 @@
       }
     },
 
-    ready() {
+    mounted() {
       if (this.visible) {
         this.rendered = true;
         this.open();
diff --git a/packages/theme-default/src/dialog.css b/packages/theme-default/src/dialog.css
index ec4ad7c59..f49a57043 100644
--- a/packages/theme-default/src/dialog.css
+++ b/packages/theme-default/src/dialog.css
@@ -8,7 +8,6 @@
     position: relative;
     margin-left: auto;
     margin-right: auto;
-    overflow: hidden;
     background: #fff;
     border-radius: 2px;
     box-shadow: 0 1px 3px rgba(0, 0, 0, 0.3);
@@ -69,20 +68,18 @@
       float: right;
     }
 
-    & *[slot=footer] {
+    @e footer {
       padding: 10px 20px 15px;
       text-align: right;
-      width: 100%;
-      display: block;
       box-sizing: border-box;
     }
   }
 
-  .dialog-fade-enter {
+  .dialog-fade-enter-active {
     animation: dialog-fade-in .3s;
   }
 
-  .dialog-fade-leave {
+  .dialog-fade-leave-active {
     animation: dialog-fade-out .3s;
   }
 

From 67ea53062ef4e1bdf9a5267e3c57e7c64c3e9514 Mon Sep 17 00:00:00 2001
From: Leopoldthecoder <Leopoldthecuber@gmail.com>
Date: Mon, 8 Aug 2016 17:22:21 +0800
Subject: [PATCH 2/2] apply v-model in el-dialog

---
 examples/docs/dialog.md           | 39 +++++++++++++++++--------------
 package.json                      |  2 +-
 packages/dialog/package.json      |  2 +-
 packages/dialog/src/component.vue |  8 +++----
 4 files changed, 27 insertions(+), 24 deletions(-)

diff --git a/examples/docs/dialog.md b/examples/docs/dialog.md
index c6da7875b..f8604a4ed 100644
--- a/examples/docs/dialog.md
+++ b/examples/docs/dialog.md
@@ -63,7 +63,7 @@
 <el-button :plain="true" v-on:click.native="dialogVisible = true">点击打开 Dialog</el-button>
 
 <div class="demo-box demo-dialog">
-  <el-dialog title="提示" :visible="dialogVisible" @open="dialogVisible = true" @close="dialogVisible = false">
+  <el-dialog title="提示" v-model="dialogVisible">
     <span>这是一段信息，这是一段信息，这是一段信息，这是一段信息，这是一段信息，这是一段信息，这是一段信息，这是一段信息</span>
     <span slot="footer" class="dialog-footer">
       <el-button @click.native="dialogVisible = false">取 消</el-button>
@@ -75,7 +75,7 @@
 ```html
 <el-button :plain="true" v-on:click.native="dialogVisible = true">点击打开 Dialog</el-button>
 
-<el-dialog title="提示" :visible="dialogVisible" @open="dialogVisible = true" @close="dialogVisible = false">
+<el-dialog title="提示" v-model="dialogVisible">
   <span>这是一段信息，这是一段信息，这是一段信息，这是一段信息，这是一段信息，这是一段信息，这是一段信息，这是一段信息</span>
   <span slot="footer" class="dialog-footer">
     <el-button @click.native="dialogVisible = false">取 消</el-button>
@@ -89,7 +89,7 @@
 <el-button :plain="true" v-on:click.native="dialogTinyVisible = true">点击打开小尺寸 Dialog</el-button>
 
 <div class="demo-box demo-dialog">
-  <el-dialog title="提示" :visible="dialogTinyVisible" size="tiny" @open="dialogTinyVisible = true" @close="dialogTinyVisible = false">
+  <el-dialog title="提示" v-model="dialogTinyVisible" size="tiny">
     <span>这是一段内容</span>
     <span slot="footer" class="dialog-footer">
       <el-button @click.native="dialogTinyVisible = false">取 消</el-button>
@@ -101,7 +101,7 @@
 ```html
 <el-button :plain="true" v-on:click.native="dialogTinyVisible = true">点击打开小尺寸 Dialog</el-button>
 
-<el-dialog title="提示" :visible="dialogTinyVisible" size="tiny" @open="dialogTinyVisible = true" @close="dialogTinyVisible = false">
+<el-dialog title="提示" v-model="dialogTinyVisible" size="tiny">
   <span>这是一段内容</span>
   <span slot="footer" class="dialog-footer">
     <el-button @click.native="dialogTinyVisible = false">取 消</el-button>
@@ -113,7 +113,7 @@
 <el-button v-on:click.native="dialogFullVisible = true">点击打开全屏幕 Dialog</el-button>
 
 <div class="demo-box demo-dialog">
-  <el-dialog title="提示" :visible="dialogFullVisible" size="full" @open="dialogFullVisible = true" @close="dialogFullVisible = false">
+  <el-dialog title="提示" v-model="dialogFullVisible" size="full">
     <img src="http://placekitten.com/1920/1280" class="full-image">
   </el-dialog>
 </div>
@@ -121,7 +121,7 @@
 ```html
 <el-button v-on:click.native="dialogFullVisible = true">点击打开全屏幕 Dialog</el-button>
 
-<el-dialog title="提示" :visible="dialogFullVisible" size="full" @open="dialogFullVisible = true" @close="dialogFullVisible = false">
+<el-dialog title="提示" v-model="dialogFullVisible" size="full">
   <img src="http://placekitten.com/1920/1280">
 </el-dialog>
 ```
@@ -132,9 +132,7 @@
 
 <div class="demo-box demo-dialog">
   <el-dialog title="提示"
-    :visible="dialogStubbornVisible"
-    @open="dialogStubbornVisible = true"
-    @close="dialogStubbornVisible = false"
+    v-model="dialogStubbornVisible"
     :close-on-click-modal="false"
     :close-on-press-escape="false">
     <span>这是一段信息，这是一段信息，这是一段信息，这是一段信息，这是一段信息，这是一段信息，这是一段信息，这是一段信息</span>
@@ -145,9 +143,7 @@
 <el-button v-on:click.native="dialogStubbornVisible = true">打开 Dialog，点击 modal 或按下 esc 关闭无法将其关闭</el-button>
 
 <el-dialog title="提示"
-  :visible="dialogStubbornVisible"
-  @open="dialogStubbornVisible = true"
-  @close="dialogStubbornVisible = false"
+  v-model="dialogStubbornVisible"
   :close-on-click-modal="false"
   :close-on-press-escape="false">
   <span>这是一段信息，这是一段信息，这是一段信息，这是一段信息，这是一段信息，这是一段信息，这是一段信息，这是一段信息</span>
@@ -159,7 +155,7 @@
 <el-button v-on:click.native="dialogTableVisible = true">打开嵌套表格的 Dialog</el-button>
 
 <div class="demo-box demo-dialog">
-  <el-dialog title="收货地址" :visible="dialogTableVisible" @open="dialogTableVisible = true" @close="dialogTableVisible = false">
+  <el-dialog title="收货地址" v-model="dialogTableVisible">
     <el-table :data="gridData">
       <el-table-column property="date" label="日期" width="150"></el-table-column>
       <el-table-column property="name" label="姓名" width="200"></el-table-column>
@@ -171,8 +167,8 @@
 <el-button v-on:click.native="dialogFormVisible = true">打开嵌套表单的 Dialog</el-button>
 
 <div class="demo-box demo-dialog">
-  <el-dialog title="收货地址" :visible="dialogFormVisible" @open="dialogFormVisible = true" @close="dialogFormVisible = false">
-    <el-form :models="form" v-ref:form>
+  <el-dialog title="收货地址" v-model="dialogFormVisible">
+    <el-form :models="form">
       <el-form-item label="活动名称" :label-width="formLabelWidth">
         <el-input :model.sync="form.name" auto-complete="off"></el-input>
       </el-form-item>
@@ -193,7 +189,7 @@
 ```html
 <el-button v-on:click.native="dialogTableVisible = true">打开嵌套表格的 Dialog</el-button>
 
-<el-dialog title="收货地址" :visible="dialogTableVisible" @open="dialogTableVisible = true" @close="dialogTableVisible = false">
+<el-dialog title="收货地址" v-model="dialogTableVisible">
   <el-table :data="gridData">
     <el-table-column property="date" label="日期" width="150"></el-table-column>
     <el-table-column property="name" label="姓名" width="200"></el-table-column>
@@ -203,8 +199,8 @@
 
 <el-button v-on:click.native="dialogFormVisible = true">打开嵌套表单的 Dialog</el-button>
 
-<el-dialog title="收货地址" :visible="dialogFormVisible" @open="dialogFormVisible = true" @close="dialogFormVisible = false">
-  <el-form :models="form" v-ref:form>
+<el-dialog title="收货地址" v-model="dialogFormVisible">
+  <el-form :models="form">
     <el-form-item label="活动名称" :label-width="formLabelWidth">
       <el-input :model.sync="form.name" auto-complete="off"></el-input>
     </el-form-item>
@@ -236,3 +232,10 @@
 |------|--------|
 | - | dialog 的内容 |
 | footer | dialog 按钮操作区的内容 |
+
+## 方法
+每个 el-dialog 实例都暴露了如下方法，用于在不使用 v-model 的情况下打开 / 关闭实例：
+| 方法名 | 说明 |
+|------|--------|
+| open | 打开当前实例 |
+| close | 关闭当前实例 |
diff --git a/package.json b/package.json
index 5ea46b612..14d06cf2c 100644
--- a/package.json
+++ b/package.json
@@ -47,7 +47,7 @@
     "vue": "^2.0.0-beta.5",
     "vue-loader": "^9.2.3",
     "vue-markdown-loader": "^0.4.0",
-    "vue-popup": "^0.2.0",
+    "vue-popup": "^0.2.1",
     "vue-router": "^2.0.0-beta.2"
   }
 }
diff --git a/packages/dialog/package.json b/packages/dialog/package.json
index 97aa9482b..a223e6050 100644
--- a/packages/dialog/package.json
+++ b/packages/dialog/package.json
@@ -12,6 +12,6 @@
   "author": "elemefe",
   "license": "MIT",
   "devDependencies": {
-    "vue-popup": "^0.2.0"
+    "vue-popup": "^0.2.1"
   }
 }
diff --git a/packages/dialog/src/component.vue b/packages/dialog/src/component.vue
index 28dc92f41..a522a848b 100644
--- a/packages/dialog/src/component.vue
+++ b/packages/dialog/src/component.vue
@@ -1,6 +1,6 @@
 <template>
   <transition name="dialog-fade">
-    <div class="el-dialog__wrapper" v-show="visible" @click.self="handleWrapperClick">
+    <div class="el-dialog__wrapper" v-show="value" @click.self="handleWrapperClick">
       <div class="el-dialog" :class="[sizeClass, customClass]" ref="dialog" :style="{ 'margin-bottom': size !== 'full' ? '50px' : '', 'top': size !== 'full' ? dynamicTop + 'px' : '0' }">
         <div class="el-dialog__header">
           <span class="el-dialog__title">{{title}}</span>
@@ -64,7 +64,7 @@
     },
 
     watch: {
-      computedVisible(val) {
+      value(val) {
         if (val) {
           this.$emit('open');
           this.$nextTick(() => {
@@ -85,7 +85,7 @@
     methods: {
       handleWrapperClick() {
         if (this.closeOnClickModal) {
-          this.computedVisible = false;
+          this.$emit('input', false);
         }
       },
 
@@ -95,7 +95,7 @@
     },
 
     mounted() {
-      if (this.visible) {
+      if (this.value) {
         this.rendered = true;
         this.open();
       }