From d1e0f9812c5f47ef91660860b4b9bb56a5d4b20c Mon Sep 17 00:00:00 2001 From: Sam Hulick Date: Mon, 22 Apr 2019 01:38:36 -0500 Subject: [PATCH] Tabs: Fixed issue where Promise rejection was hitting application (#14816) --- packages/tabs/src/tabs.vue | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/packages/tabs/src/tabs.vue b/packages/tabs/src/tabs.vue index 45cad6903..733fbb831 100644 --- a/packages/tabs/src/tabs.vue +++ b/packages/tabs/src/tabs.vue @@ -92,11 +92,14 @@ if (this.currentName !== value && this.beforeLeave) { const before = this.beforeLeave(value, this.currentName); if (before && before.then) { - before.then(() => { - changeCurrentName(); - - this.$refs.nav && this.$refs.nav.removeFocus(); - }); + before + .then(() => { + changeCurrentName(); + this.$refs.nav && this.$refs.nav.removeFocus(); + }, () => { + // https://github.com/ElemeFE/element/pull/14816 + // ignore promise rejection in `before-leave` hook + }); } else if (before !== false) { changeCurrentName(); }