From b386105913de793b0cbc658338ca7aaff0b34b50 Mon Sep 17 00:00:00 2001 From: v_byqbai Date: Thu, 15 Jul 2021 11:46:49 +0800 Subject: [PATCH] Test: vue-popper del appended val --- src/utils/vue-popper.js | 3 ++- test/unit/specs/util.vue-popper.spec.js | 2 -- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/src/utils/vue-popper.js b/src/utils/vue-popper.js index c89c5f7d9..50fb07a05 100644 --- a/src/utils/vue-popper.js +++ b/src/utils/vue-popper.js @@ -164,9 +164,10 @@ export default { }, appendArrow(element) { + if (!element) return; let hash; let arrowClassName = 'popper__arrow'; - if (element.getElementsByClassName(arrowClassName).length) { + if (element && element.querySelector('[x-arrow]')) { return; } diff --git a/test/unit/specs/util.vue-popper.spec.js b/test/unit/specs/util.vue-popper.spec.js index 8c6238769..13eb0f0dd 100644 --- a/test/unit/specs/util.vue-popper.spec.js +++ b/test/unit/specs/util.vue-popper.spec.js @@ -141,10 +141,8 @@ describe('Utils:VuePopper', () => { }); expect(vm.appended).to.be.undefined; vm.createPopper(); - expect(vm.appended).to.true; vm.appendArrow(); expect(vm.popperJS._popper.querySelector('[x-arrow]')).to.exist; - expect(vm.appended).to.true; }); it('appendArrow: add scoped', () => {