github
/
element
mirror of https://github.com/ElemeFE/element
1
0
Fork 0
Code Issues Releases Wiki Activity

DatePicker: fix incorrect interaction on range change when defaultTime provided

pull/9329/merge
nighca 2018-01-17 11:14:10 +08:00 committed by 杨奕
parent 23a60a0ef6
commit 2880132de8
2 changed files with 34 additions and 29 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
packages/date-picker/src/panel/date-range.vue
View File

@ -426,9 +426,8 @@
}, },
handleChangeRange(val) { handleChangeRange(val) {
const defaultTime = this.defaultTime || []; this.minDate = val.minDate;
this.minDate = modifyWithGivenTime(val.minDate, defaultTime[0]); this.maxDate = val.maxDate;
this.maxDate = modifyWithGivenTime(val.maxDate, defaultTime[1]);
this.rangeState = val.rangeState; this.rangeState = val.rangeState;
}, },

58
test/unit/specs/date-picker.spec.js
View File

@ -1272,20 +1272,23 @@ describe('DatePicker', () => {
triggerEvent(leftCell, 'click', true); triggerEvent(leftCell, 'click', true);
setTimeout(_ => { setTimeout(_ => {
triggerEvent(rightCell, 'mousemove', true); triggerEvent(rightCell, 'mousemove', true);
triggerEvent(rightCell, 'click', true);
setTimeout(_ => { setTimeout(_ => {
const { expect(rightCell.classList.contains('in-range')).to.be.true;
minDate,
maxDate triggerEvent(rightCell, 'click', true);
} = vmWithDefaultTime.picker; setTimeout(_ => {
expect(minDate.getHours()).to.be.equal(11); const {
expect(minDate.getMinutes()).to.be.equal(59); minDate,
expect(minDate.getSeconds()).to.be.equal(59); maxDate
expect(maxDate.getHours()).to.be.equal(0); } = vmWithDefaultTime.picker;
expect(maxDate.getMinutes()).to.be.equal(0); expect(minDate.getHours()).to.be.equal(11);
expect(maxDate.getSeconds()).to.be.equal(0); expect(minDate.getMinutes()).to.be.equal(59);
done(); expect(minDate.getSeconds()).to.be.equal(59);
expect(maxDate.getHours()).to.be.equal(0);
expect(maxDate.getMinutes()).to.be.equal(0);
expect(maxDate.getSeconds()).to.be.equal(0);
done();
}, DELAY);
}, DELAY); }, DELAY);
}, DELAY); }, DELAY);
}, DELAY); }, DELAY);
@ -1317,20 +1320,23 @@ describe('DatePicker', () => {
triggerEvent(leftCell, 'click', true); triggerEvent(leftCell, 'click', true);
setTimeout(_ => { setTimeout(_ => {
triggerEvent(rightCell, 'mousemove', true); triggerEvent(rightCell, 'mousemove', true);
triggerEvent(rightCell, 'click', true);
setTimeout(_ => { setTimeout(_ => {
const { expect(rightCell.classList.contains('in-range')).to.be.true;
minDate,
maxDate triggerEvent(rightCell, 'click', true);
} = vmWithDefaultTime.picker; setTimeout(_ => {
expect(minDate.getHours()).to.be.equal(11); const {
expect(minDate.getMinutes()).to.be.equal(59); minDate,
expect(minDate.getSeconds()).to.be.equal(59); maxDate
expect(maxDate.getHours()).to.be.equal(18); } = vmWithDefaultTime.picker;
expect(maxDate.getMinutes()).to.be.equal(0); expect(minDate.getHours()).to.be.equal(11);
expect(maxDate.getSeconds()).to.be.equal(0); expect(minDate.getMinutes()).to.be.equal(59);
done(); expect(minDate.getSeconds()).to.be.equal(59);
expect(maxDate.getHours()).to.be.equal(18);
expect(maxDate.getMinutes()).to.be.equal(0);
expect(maxDate.getSeconds()).to.be.equal(0);
done();
}, DELAY);
}, DELAY); }, DELAY);
}, DELAY); }, DELAY);
}, DELAY); }, DELAY);