github
/
element
mirror of https://github.com/ElemeFE/element
1
0
Fork 0
Code Issues Releases Wiki Activity

Tabs: rerender when slot changes (#15238)

pull/15190/head^2
hetech 2019-04-24 11:32:42 +08:00 committed by iamkun
parent 73ca7be647
commit 0325e1dc4d
2 changed files with 5 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
packages/tabs/src/tab-pane.vue
View File

@ -49,10 +49,8 @@
} }
}, },
watch: { updated() {
label() { this.$parent.$emit('tab-nav-update');
this.$parent.$emit('tabLabelChanged');
}
} }
}; };
</script> </script>

6
packages/tabs/src/tabs.vue
View File

@ -55,14 +55,14 @@
}, },
methods: { methods: {
calcPaneInstances(isLabelUpdated = false) { calcPaneInstances(isForceUpdate = false) {
if (this.$slots.default) { if (this.$slots.default) {
const paneSlots = this.$slots.default.filter(vnode => vnode.tag && const paneSlots = this.$slots.default.filter(vnode => vnode.tag &&
vnode.componentOptions && vnode.componentOptions.Ctor.options.name === 'ElTabPane'); vnode.componentOptions && vnode.componentOptions.Ctor.options.name === 'ElTabPane');
// update indeed // update indeed
const panes = paneSlots.map(({ componentInstance }) => componentInstance); const panes = paneSlots.map(({ componentInstance }) => componentInstance);
const panesChanged = !(panes.length === this.panes.length && panes.every((pane, index) => pane === this.panes[index])); const panesChanged = !(panes.length === this.panes.length && panes.every((pane, index) => pane === this.panes[index]));
if (isLabelUpdated || panesChanged) { if (isForceUpdate || panesChanged) {
this.panes = panes; this.panes = panes;
} }
} else if (this.panes.length !== 0) { } else if (this.panes.length !== 0) {
@ -177,7 +177,7 @@
this.setCurrentName('0'); this.setCurrentName('0');
} }
this.$on('tabLabelChanged', this.calcPaneInstances.bind(null, true)); this.$on('tab-nav-update', this.calcPaneInstances.bind(null, true));
}, },
mounted() { mounted() {