From 1cf6ee40b1306b32293c7e310d19b9a6de584325 Mon Sep 17 00:00:00 2001 From: researchlive <64801492+researchlive@users.noreply.github.com> Date: Mon, 4 May 2020 13:37:38 -0400 Subject: [PATCH] One method name is not clear The original method name is not clear enough to describe the work of the method. In fact, this method is used to search all matched results. But the original name "getDicts" may make developers misunderstand this method that is used to create dictionaries or some other works. I just would like to make it clear about this problem. --- .../java/me/zhengjie/modules/system/rest/DictController.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/eladmin-system/src/main/java/me/zhengjie/modules/system/rest/DictController.java b/eladmin-system/src/main/java/me/zhengjie/modules/system/rest/DictController.java index 4e2d8107..ceadf35f 100644 --- a/eladmin-system/src/main/java/me/zhengjie/modules/system/rest/DictController.java +++ b/eladmin-system/src/main/java/me/zhengjie/modules/system/rest/DictController.java @@ -55,7 +55,7 @@ public class DictController { @ApiOperation("查询字典") @GetMapping @PreAuthorize("@el.check('dict:list')") - public ResponseEntity getDicts(DictQueryCriteria resources, Pageable pageable){ + public ResponseEntity getByQuery(DictQueryCriteria resources, Pageable pageable){ return new ResponseEntity<>(dictService.queryAll(resources,pageable),HttpStatus.OK); } @@ -87,4 +87,4 @@ public class DictController { dictService.delete(ids); return new ResponseEntity<>(HttpStatus.OK); } -} \ No newline at end of file +}