consul/ui-v2
John Cowen 40e71f1b91
UI: Simplify/refactor the actions/notification layer (#4572) + (#4573)
* Move notification texts to a slightly different layer (#4572)
* Further Simplify/refactor the actions/notification layer (#4573)

1. Move the 'with-feedback' actions to a 'with-blocking-action' mixin
which better describes what it does
2. Additional set of unit tests almost over the entire layer to prove
things work/add confidence for further changes

The multiple 'with-action' mixins used for every 'index/edit' combo are
now reduced down to only contain the functionality related to their
specific routes, i.e. where to redirect.

The actual functionality to block and carry out the action and then
notify are 'almost' split out so that their respective classes/objects do
one thing and one thing 'well'.

Mixins are chosen for the moment as the decoration approach used by
mixins feels better than multiple levels of inheritence, but I would
like to take this fuether in the future to a 'compositional' based
approach.

There is still possible further work to be done here, but I'm a lot
happier now this is reduced down into separate parts.
2018-08-29 19:14:31 +01:00
..
app UI: Simplify/refactor the actions/notification layer (#4572) + (#4573) 2018-08-29 19:14:31 +01:00
config UI: Add conditional enterprise logo (#4432) 2018-07-30 17:59:43 +01:00
lib UI: Add conditional enterprise logo (#4432) 2018-07-30 17:59:43 +01:00
public
tests UI: Simplify/refactor the actions/notification layer (#4572) + (#4573) 2018-08-29 19:14:31 +01:00
.dev.eslintrc.js
.editorconfig
.ember-cli Move testing doubles to use data embedded in the HTML vs HTTP/fetch 2018-07-02 19:02:16 +01:00
.eslintrc.js
.gitignore
.nvmrc
.prettierrc
.watchmanconfig
GNUmakefile Move testing doubles to use data embedded in the HTML vs HTTP/fetch 2018-07-02 19:02:16 +01:00
README.md Add some more detail to the README pre-adding a CONTRIBUTING 2018-07-05 09:20:58 +01:00
ember-cli-build.js UI: Simplify/refactor the actions/notification layer (#4572) + (#4573) 2018-08-29 19:14:31 +01:00
package.json UI: Simplify/refactor the actions/notification layer (#4572) + (#4573) 2018-08-29 19:14:31 +01:00
testem.js
yarn.lock UI: Simplify/refactor the actions/notification layer (#4572) + (#4573) 2018-08-29 19:14:31 +01:00

README.md

consul-ui

Prerequisites

You will need the following things properly installed on your computer.

Installation

  • git clone https://github.com/hashicorp/consul.git this repository
  • cd ui-v2
  • yarn install

Running / Development

Code Generators

Make use of the many generators for code, try ember help generate for more details

Running Tests

You do not need to run make start-api/yarn run start:api to run the tests

  • make test or yarn run test
  • make test-view or yarn run test:view to view the tests running in Chrome