consul

History

R.B. Boyer e3cd4a8539 connect: use stronger validation that ingress gateways have compatible protocols defined for their upstreams (#8470 ) Fixes #8466 Since Consul 1.8.0 there was a bug in how ingress gateway protocol compatibility was enforced. At the point in time that an ingress-gateway config entry was modified the discovery chain for each upstream was checked to ensure the ingress gateway protocol matched. Unfortunately future modifications of other config entries were not validated against existing ingress-gateway definitions, such as: 1. create tcp ingress-gateway pointing to 'api' (ok) 2. create service-defaults for 'api' setting protocol=http (worked, but not ok) 3. create service-splitter or service-router for 'api' (worked, but caused an agent panic) If you were to do these in a different order, it would fail without a crash: 1. create service-defaults for 'api' setting protocol=http (ok) 2. create service-splitter or service-router for 'api' (ok) 3. create tcp ingress-gateway pointing to 'api' (fail with message about protocol mismatch) This PR introduces the missing validation. The two new behaviors are: 1. create tcp ingress-gateway pointing to 'api' (ok) 2. (NEW) create service-defaults for 'api' setting protocol=http ("ok" for back compat) 3. (NEW) create service-splitter or service-router for 'api' (fail with message about protocol mismatch) In consideration for any existing users that may be inadvertently be falling into item (2) above, that is now officiall a valid configuration to be in. For anyone falling into item (3) above while you cannot use the API to manufacture that scenario anymore, anyone that has old (now bad) data will still be able to have the agent use them just enough to generate a new agent/proxycfg error message rather than a panic. Unfortunately we just don't have enough information to properly fix the config entries.		4 years ago
..
proxysupport	xds: add support for envoy 1.15.0 and drop support for 1.11.x (#8424 )	4 years ago
testdata	xds: add support for envoy 1.15.0 and drop support for 1.11.x (#8424 )	4 years ago
clusters.go	xds: version sniff envoy and switch regular expressions from 'regex' to 'safe_regex' on newer envoy versions (#8222 )	4 years ago
clusters_test.go	xds: add support for envoy 1.15.0 and drop support for 1.11.x (#8424 )	4 years ago
config.go	connect: upgrade github.com/envoyproxy/go-control-plane to v0.9.5 (#8165 )	4 years ago
config_test.go	…
endpoints.go	xds: version sniff envoy and switch regular expressions from 'regex' to 'safe_regex' on newer envoy versions (#8222 )	4 years ago
endpoints_test.go	xds: add support for envoy 1.15.0 and drop support for 1.11.x (#8424 )	4 years ago
envoy_versioning.go	xds: add support for envoy 1.15.0 and drop support for 1.11.x (#8424 )	4 years ago
envoy_versioning_test.go	xds: version sniff envoy and switch regular expressions from 'regex' to 'safe_regex' on newer envoy versions (#8222 )	4 years ago
failover_math.go	…
failover_math_test.go	…
golden_test.go	xds: version sniff envoy and switch regular expressions from 'regex' to 'safe_regex' on newer envoy versions (#8222 )	4 years ago
listeners.go	connect: use stronger validation that ingress gateways have compatible protocols defined for their upstreams (#8470 )	4 years ago
listeners_test.go	xds: add support for envoy 1.15.0 and drop support for 1.11.x (#8424 )	4 years ago
naming.go	…
response.go	connect: upgrade github.com/envoyproxy/go-control-plane to v0.9.5 (#8165 )	4 years ago
routes.go	connect: use stronger validation that ingress gateways have compatible protocols defined for their upstreams (#8470 )	4 years ago
routes_test.go	xds: add support for envoy 1.15.0 and drop support for 1.11.x (#8424 )	4 years ago
server.go	xds: add support for envoy 1.15.0 and drop support for 1.11.x (#8424 )	4 years ago
server_oss.go	…
server_test.go	Fix a bunch of unparam lint issues	4 years ago
testing.go	connect: upgrade github.com/envoyproxy/go-control-plane to v0.9.5 (#8165 )	4 years ago
xds.go	…