mirror of https://github.com/hashicorp/consul
e8312d6b5a
Previously we believe it was necessary for all code that required ports to use freeport to prevent conflicts. https://github.com/dnephin/freeport-test shows that it is actually save to use port 0 (`127.0.0.1:0`) as long as it is passed directly to `net.Listen`, and the listener holds the port for as long as it is needed. This works because freeport explicitly avoids the ephemeral port range, and port 0 always uses that range. As you can see from the test output of https://github.com/dnephin/freeport-test, the two systems never use overlapping ports. This commit converts all uses of freeport that were being passed directly to a net.Listen to use port 0 instead. This allows us to remove a bit of wrapping we had around httptest, in a couple places. |
||
|---|---|---|
| .. | ||
| internal/strutil | ||
| oidcauthtest | ||
| auth.go | ||
| config.go | ||
| config_test.go | ||
| jwt.go | ||
| jwt_test.go | ||
| oidc.go | ||
| oidc_test.go | ||
| oidcjwt.go | ||
| oidcjwt_test.go | ||
| util.go | ||
| util_test.go | ||