github
/
consul
mirror of https://github.com/hashicorp/consul
1
0
Fork 0
Code Issues Projects Releases Wiki Activity
consul/ui-v2/tests/acceptance
History
John Cowen 9013e53ebc
ui: Ensures nested policy forms are reset properly (#5838) 
1. All {{ivy-codemirror}} components need 'refreshing' when they become
visible via our own `didAppear` method on the `{{code-editor}}`
component

(also see:)
- https://github.com/hashicorp/consul/pull/4190#discussion_r193270223
- 73db111db8 (r225264296)

2. On initial investigation, it looks like the component we are using
for the code editor doesn't distinguish between setting its `value`
programatically and a `keyup` event, i.e. an interaction from the user.
We currently pretend that whenever its `value` changes, it is a `keyup`
event. This means that when we reset the `value` to `""`
programmatically for form resetting purposes, a 'pretend keyup' event
would also be fired, which would in turn kick off the validation, which
would fail and show an error message for empty values in other fields of
the form - something that is perfectly valid if you haven't typed
anything yet. We solved this by checking for `isPristine` on fields that
are allowed to be empty before you have typed anything.
 		2019-06-04 15:57:35 +01:00
..
components ui: Search improvements (#5540) 2019-05-01 18:22:36 +00:00
dc ui: Ensures nested policy forms are reset properly (#5838) 2019-06-04 15:57:35 +01:00
settings UI: New ACLs (#4789) 2018-10-19 08:45:05 -07:00
steps ui: Ensures nested policy forms are reset properly (#5838) 2019-06-04 15:57:35 +01:00
deleting.feature UI: ACL Roles (#5635) 2019-05-01 18:22:37 +00:00
index-forwarding.feature WIP: Feature/acceptance tests 2018-06-12 11:24:35 +01:00
page-navigation.feature UI: ACL Roles (#5635) 2019-05-01 18:22:37 +00:00
startup.feature Reset `<html class>` after every test, back to its original static value 2018-06-25 12:11:01 +01:00
submit-blank.feature Add some low hanging intention tests, basically add intentions to others 2018-07-04 13:21:30 +01:00
token-header.feature UI: Catch 500 error on token endpoint and revert to legacy tokens (#4874) 2018-11-02 14:44:36 +00:00