R.B. Boyer 64271289ec server: partly fix config entry replication issue that prevents replication in some circumstances (#12307) ... There are some cross-config-entry relationships that are enforced during "graph validation" at persistence time that are required to be maintained. This means that config entries may form a digraph at times. Config entry replication procedes in a particular sorted order by kind and name. Occasionally there are some fixups to these digraphs that end up replicating in the wrong order and replicating the leaves (ingress-gateway) before the roots (service-defaults) leading to replication halting due to a graph validation error related to things like mismatched service protocol requirements. This PR changes replication to give each computed change (upsert/delete) a fair shot at being applied before deciding to terminate that round of replication in error. In the case where we've simply tried to do the operations in the wrong order at least ONE of the outstanding requests will complete in the right order, leading the subsequent round to have fewer operations to do, with a smaller likelihood of graph validation errors. This does not address all scenarios, but for scenarios where the edits are being applied in the wrong order this should avoid replication halting. Fixes #9319 The scenario that is NOT ADDRESSED by this PR is as follows: 1. create: service-defaults: name=new-web, protocol=http 2. create: service-defaults: name=old-web, protocol=http 3. create: service-resolver: name=old-web, redirect-to=new-web 4. delete: service-resolver: name=old-web 5. update: service-defaults: name=old-web, protocol=grpc 6. update: service-defaults: name=new-web, protocol=grpc 7. create: service-resolver: name=old-web, redirect-to=new-web If you shutdown dc2 just before (4) and turn it back on after (7) replication is impossible as there is no single edit you can make to make forward progress.		2022-02-23 17:27:48 -06:00
..
ae	sdk: add TestLogLevel for setting log level in tests	2022-02-03 13:42:28 -05:00
auto-config	Rename `Master` and `AgentMaster` fields in config protobuf (#11764)	2021-12-07 19:59:38 +00:00
cache	bulk rewrite using this script	2022-01-20 10:46:23 -06:00
cache-types	bulk rewrite using this script	2022-01-20 10:46:23 -06:00
checks	re-run gofmt on 1.17 (#11579)	2021-11-16 12:04:01 -06:00
config	file watcher to be used for configuration auto-reload feature (#12301)	2022-02-21 11:36:52 -05:00
configentry	configentry: make a new package to hold shared config entry structs that aren't used for RPC or the FSM (#12384)	2022-02-22 10:36:36 -06:00
connect	Update TODOs to reference an issue with more details	2022-02-17 18:21:30 -05:00
consul	server: partly fix config entry replication issue that prevents replication in some circumstances (#12307)	2022-02-23 17:27:48 -06:00
debug	bulk rewrite using this script	2022-01-20 10:46:23 -06:00
dns	…
exec	re-run gofmt on 1.17 (#11579)	2021-11-16 12:04:01 -06:00
grpc	Merge remote-tracking branch 'origin/main' into serve-panic-recovery	2021-12-07 16:30:41 -05:00
local	missed this test adjustment (#12331)	2022-02-14 11:39:00 -06:00
metadata	partitions: various refactors to support partitioning the serf LAN pool (#11568)	2021-11-15 09:51:14 -06:00
mock	…
pool	Vendor in rpc mono repo for net/rpc fork, go-msgpack, msgpackrpc. (#12311)	2022-02-14 09:45:45 -08:00
proxycfg	Account for upstream targets in another DC.	2022-02-10 17:01:57 -07:00
router	sdk: add TestLogLevel for setting log level in tests	2022-02-03 13:42:28 -05:00
routine-leak-checker	Remove references to "master" ACL tokens in tests (#11751)	2021-12-07 12:48:50 +00:00
rpc/subscribe	streaming: split event buffer by key (#12080)	2022-01-28 12:27:00 +00:00
rpcclient/health	…
structs	Merge pull request #11910 from hashicorp/dnephin/ca-provider-interface-for-ica-in-primary	2022-02-22 13:14:52 -05:00
submatview	…
systemd	…
token	agent/token: rename `agent_master` to `agent_recovery` (internally) (#11744)	2021-12-07 12:12:47 +00:00
uiserver	auto-updated agent/uiserver/bindata_assetfs.go from commit 73b6687c5	2022-02-21 12:27:52 +00:00
xds	xds: respect chain protocol on default discovery chain	2022-02-17 11:47:20 -08:00
acl.go	Refactor to make ACL errors more structured. (#12308)	2022-02-11 12:53:23 -08:00
acl_endpoint.go	Parse datacenter from request (#12370)	2022-02-17 16:41:27 -05:00
acl_endpoint_legacy.go	…
acl_endpoint_legacy_test.go	…
acl_endpoint_test.go	Parse datacenter from request (#12370)	2022-02-17 16:41:27 -05:00
acl_oss.go	agent: support `X-Consul-Results-Filtered-By-ACLs` header in agent-local endpoints (#11610)	2021-12-03 20:36:28 +00:00
acl_test.go	sdk: add TestLogLevel for setting log level in tests	2022-02-03 13:42:28 -05:00
agent.go	checks: populate interval and timeout when registering services (#11138)	2022-02-18 12:05:33 -08:00
agent_endpoint.go	Refactor to make ACL errors more structured. (#12308)	2022-02-11 12:53:23 -08:00
agent_endpoint_oss.go	re-run gofmt on 1.17 (#11579)	2021-11-16 12:04:01 -06:00
agent_endpoint_test.go	acl: return a resposne from ResolveToken that includes the ACLIdentity	2022-01-22 14:33:09 -05:00
agent_oss.go	re-run gofmt on 1.17 (#11579)	2021-11-16 12:04:01 -06:00
agent_test.go	checks: populate interval and timeout when registering services (#11138)	2022-02-18 12:05:33 -08:00
apiserver.go	…
apiserver_test.go	…
catalog_endpoint.go	Change error-handling across handlers. (#12225)	2022-01-31 11:17:35 -05:00
catalog_endpoint_oss.go	re-run gofmt on 1.17 (#11579)	2021-11-16 12:04:01 -06:00
catalog_endpoint_test.go	bulk rewrite using this script	2022-01-20 10:46:23 -06:00
check.go	…
config_endpoint.go	Change error-handling across handlers. (#12225)	2022-01-31 11:17:35 -05:00
config_endpoint_test.go	bulk rewrite using this script	2022-01-20 10:46:23 -06:00
connect_auth.go	…
connect_ca_endpoint.go	…
connect_ca_endpoint_test.go	bulk rewrite using this script	2022-01-20 10:46:23 -06:00
coordinate_endpoint.go	Change error-handling across handlers. (#12225)	2022-01-31 11:17:35 -05:00
coordinate_endpoint_test.go	Change error-handling across handlers. (#12225)	2022-01-31 11:17:35 -05:00
delegate_mock_test.go	acl: remove unused methods on fakes, and add changelog	2022-01-31 17:53:53 -05:00
denylist.go	…
denylist_test.go	…
discovery_chain_endpoint.go	Change error-handling across handlers. (#12225)	2022-01-31 11:17:35 -05:00
discovery_chain_endpoint_test.go	…
dns.go	dns: add endpoint for querying service virtual IPs	2021-12-02 16:40:28 -08:00
dns_oss.go	re-run gofmt on 1.17 (#11579)	2021-11-16 12:04:01 -06:00
dns_test.go	Remove references to "master" ACL tokens in tests (#11751)	2021-12-07 12:48:50 +00:00
enterprise_delegate_oss.go	re-run gofmt on 1.17 (#11579)	2021-11-16 12:04:01 -06:00
event_endpoint.go	Change error-handling across handlers. (#12225)	2022-01-31 11:17:35 -05:00
event_endpoint_test.go	Change error-handling across handlers. (#12225)	2022-01-31 11:17:35 -05:00
federation_state_endpoint.go	URL-encode/decode resource names for HTTP API part 3 (#12103)	2022-01-26 13:12:42 -05:00
health_endpoint.go	URL-encode/decode resource names for HTTP API part 5 (#12297)	2022-02-14 10:47:06 -05:00
health_endpoint_test.go	Change error-handling across handlers. (#12225)	2022-01-31 11:17:35 -05:00
http.go	Change error-handling across handlers. (#12225)	2022-01-31 11:17:35 -05:00
http_decode_test.go	…
http_oss.go	re-run gofmt on 1.17 (#11579)	2021-11-16 12:04:01 -06:00
http_oss_test.go	Remove references to "master" ACL tokens in tests (#11751)	2021-12-07 12:48:50 +00:00
http_register.go	cleanup: Clarify deprecated legacy intention endpoints (#11635)	2021-11-23 19:32:18 -05:00
http_test.go	testing: fix test failures caused by new log level	2022-02-03 17:07:39 -05:00
intentions_endpoint.go	Change error-handling across handlers. (#12225)	2022-01-31 11:17:35 -05:00
intentions_endpoint_oss_test.go	re-run gofmt on 1.17 (#11579)	2021-11-16 12:04:01 -06:00
intentions_endpoint_test.go	…
keyring.go	…
keyring_test.go	Remove references to "master" ACL tokens in tests (#11751)	2021-12-07 12:48:50 +00:00
kvs_endpoint.go	Change error-handling across handlers. (#12225)	2022-01-31 11:17:35 -05:00
kvs_endpoint_test.go	…
metrics.go	…
metrics_test.go	…
nodeid.go	…
nodeid_test.go	…
notify.go	…
notify_test.go	…
operator_endpoint.go	partitions: various refactors to support partitioning the serf LAN pool (#11568)	2021-11-15 09:51:14 -06:00
operator_endpoint_oss.go	re-run gofmt on 1.17 (#11579)	2021-11-16 12:04:01 -06:00
operator_endpoint_test.go	…
prepared_query_endpoint.go	Change error-handling across handlers. (#12225)	2022-01-31 11:17:35 -05:00
prepared_query_endpoint_test.go	Change error-handling across handlers. (#12225)	2022-01-31 11:17:35 -05:00
reload.go	…
remote_exec.go	…
remote_exec_test.go	Remove references to "master" ACL tokens in tests (#11751)	2021-12-07 12:48:50 +00:00
retry_join.go	…
retry_join_test.go	…
service_checks_test.go	…
service_manager.go	…
service_manager_test.go	bulk rewrite using this script	2022-01-20 10:46:23 -06:00
session_endpoint.go	Change error-handling across handlers. (#12225)	2022-01-31 11:17:35 -05:00
session_endpoint_test.go	…
setup.go	…
setup_oss.go	re-run gofmt on 1.17 (#11579)	2021-11-16 12:04:01 -06:00
sidecar_service.go	…
sidecar_service_test.go	bulk rewrite using this script	2022-01-20 10:46:23 -06:00
signal_unix.go	re-run gofmt on 1.17 (#11579)	2021-11-16 12:04:01 -06:00
signal_windows.go	re-run gofmt on 1.17 (#11579)	2021-11-16 12:04:01 -06:00
snapshot_endpoint.go	…
snapshot_endpoint_test.go	…
status_endpoint.go	…
status_endpoint_test.go	…
streaming_test.go	…
testagent.go	testing: fix test failures caused by new log level	2022-02-03 17:07:39 -05:00
testagent_test.go	…
translate_addr.go	…
txn_endpoint.go	Change error-handling across handlers. (#12225)	2022-01-31 11:17:35 -05:00
txn_endpoint_test.go	Change error-handling across handlers. (#12225)	2022-01-31 11:17:35 -05:00
ui_endpoint.go	Support for connect native services in topology view. (#12098)	2022-02-16 16:51:54 -05:00
ui_endpoint_oss_test.go	re-run gofmt on 1.17 (#11579)	2021-11-16 12:04:01 -06:00
ui_endpoint_test.go	Support for connect native services in topology view. (#12098)	2022-02-16 16:51:54 -05:00
user_event.go	Vendor in rpc mono repo for net/rpc fork, go-msgpack, msgpackrpc. (#12311)	2022-02-14 09:45:45 -08:00
user_event_test.go	…
util.go	…
util_test.go	…
watch_handler.go	…
watch_handler_test.go	…