mirror of https://github.com/hashicorp/consul
1f00ede559
Previously we were using two different criteria to decide where to run a test. The main `go-test` job would skip Vault tests based on the presence of the `vault` binary, but the `test-connect-ca-providers` job would run tests based on the name. This led to a scenario where a test may never run in CI. To fix this problem I added a name check to the function we use to skip the test. This should ensure that any test that requires vault is named correctly to be run as part of the `test-connect-ca-providers` job. At the same time I relaxed the regex we use. I verified this runs the same tests using `go test --list Vault`. I made this change because a bunch of tests in `agent/connect/ca` used `Vault` in the name, without the underscores. Instead of changing a bunch of test names, this seemed easier. With this approach, the worst case is that we run a few extra tests in the `test-connect-ca-providers` job, which doesn't seem like a problem. |
||
|---|---|---|
| .. | ||
| common.go | ||
| mock_Provider.go | ||
| provider.go | ||
| provider_aws.go | ||
| provider_aws_test.go | ||
| provider_consul.go | ||
| provider_consul_config.go | ||
| provider_consul_test.go | ||
| provider_test.go | ||
| provider_vault.go | ||
| provider_vault_test.go | ||
| testing.go | ||